On Thu, Sep 17, 2015 at 11:45:20AM -0700, Samudrala, Sridhar wrote:
On 9/17/2015 12:42 AM, Jiri Pirko wrote:
>Can you please provide some more info about this change, like when in
>the spec this is decribed? Thanks!
Section 5.3.15 in 802.1ax spec defines these flags
http://varlyakov.com/diplomna/diplomna/802.1ax/802.1ax.pdf
Here is another link that describes the LACP flags.
http://networkingbodges.blogspot.com/2012/12/all-sorts-of-things-about-la...
Are you actually seeing a bug without this patch?
COLLECTING and DISTRIBUTING are informative bits about the port's
state, but they are secondary to other states like SYNCHRONIZATION,
so I don't see how that can cause an issue.
With the proposed patch applied, there could be an outage if
the state moves to EXPIRED or DEFAULTED.
So, without more details for this change, NACK.
fbl
Thanks
Sridhar
>
>
>Thu, Sep 17, 2015 at 12:47:36AM CEST, sridhar.samudrala(a)intel.com wrote:
>>Signed-off-by: Sridhar Samudrala <sridhar.samudrala(a)intel.com>
>>---
>>teamd/teamd_runner_lacp.c | 3 ++-
>>1 file changed, 2 insertions(+), 1 deletion(-)
>>
>>diff --git a/teamd/teamd_runner_lacp.c b/teamd/teamd_runner_lacp.c
>>index 09899ce..f663016 100644
>>--- a/teamd/teamd_runner_lacp.c
>>+++ b/teamd/teamd_runner_lacp.c
>>@@ -900,7 +900,8 @@ static int lacp_port_actor_update(struct lacp_port
*lacp_port)
>> state |= INFO_STATE_LACP_TIMEOUT;
>> if (lacp_port_selected(lacp_port))
>> state |= INFO_STATE_SYNCHRONIZATION;
>>- state |= INFO_STATE_COLLECTING | INFO_STATE_DISTRIBUTING;
>>+ if (lacp_port->state == PORT_STATE_CURRENT)
>>+ state |= INFO_STATE_COLLECTING | INFO_STATE_DISTRIBUTING;
>> if (lacp_port->state == PORT_STATE_EXPIRED)
>> state |= INFO_STATE_EXPIRED;
>> if (lacp_port->state == PORT_STATE_DEFAULTED)
>>--
>>2.1.0
>>
_______________________________________________
libteam mailing list
libteam(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/libteam