On Wed, May 11, 2016 at 8:00 PM, Neal Gompa
<ngompa13(a)gmail.com> wrote:
> On Wed, May 11, 2016 at 8:22 PM, Mike Bonnet <mikeb(a)redhat.com> wrote:
>> On 5/11/16 2:37 PM, Mike McLean wrote:
>>>
>>> json is the python standard lib for json in 2.6+. It is based on
>>> simplejson, which remains a separate lib and advances faster than the
>>> core one (and is also backported to python <2.6). They are very similar,
>>> but apparently there are some gotchas.
>>>
>>> I anticipate using json more and more in koji. I guess my question is
>>> whether we should embrace one over the other. Right now, we're trying
>>> json and falling back to simplejson in some client code, but simply
>>> using simplejson in the hub code.
>>>
>>> At the moment, we still support RHEL5 as a target (that means python
>>> 2.4.3), but I'm hoping to drop that in the nearish future, but in the
>>> meantime that means we need to at least be able to fall back to
>>> simplejson.
>>>
>>> There are mixed reports on performance. Some say simplejson is much
>>> faster, others say they are roughly comparable.
>>>
>>> Also apparently there is a bit of a behavior difference wrt unicode
>>>
>>>
>>>
https://stackoverflow.com/questions/712791/what-are-the-differences-betwe...
>>>
>>>
https://code.google.com/archive/p/simplejson/issues/40
>>
>>
>> In the interest of removing a dependency, I'd support dropping RHEL-5
>> support and using json everywhere.
>>
>
> I agree here, and strongly suggest Koji moves forward with using the
> built-in json module in python. Less external dependencies makes it
> much easier to track and update.
>
+1 for mainline python json module
+1 here too.
Many #fedora-apps apps had deps on simplejson from back-when. We've
been slowly removing those over the years and are almost entirely on
the stdlib json module these days.