On Mon, Feb 24, 2020 at 1:55 AM Tomas Kopecek <tkopecek(a)redhat.com> wrote:
Hi,
question for all: how are you using koji-usage (if you even know about their existence)?
This is a bunch of random script with various level of maturity living in pagure [1].
They are nor packaged, nor distributed anywhere. I've gone through old PRs there and
seen one from Pavol Babincak proposing setup.py. Maybe it makes sense for someone to have
it installed in virtualenv, maybe it also makes sense to provide some basic spec file
(that was my PR proposing splitting these tools to cli plugins and rest). Not sure about
ad hoc PyPi distribution.
We don't plan to give it much better shape, but for some more mature scripts it would
make sense to promote them to basic koji (blinking in koji-ssl-admin direction). I'll
add some paragraph about this possibility to README.md there.
I would be happy to see koji-ssl-admin go into the main koji CLI. The
only dependencies are python-cryptography and /usr/bin/openssl.
The cli/koji_cli/commands.py file is massive at this point, and I
don't want to make that problem worse. I (naively) think it would make
more sense to refactor cli/koji_cli/commands.py into a
cli/koji_cli/commands/ directory and to put each sub-command into its
own Python file.
I have a couple more scripts that I have not proposed to koji-tools
yet because they might be better suited elsewhere. I also opened this
ticket recently about possibly moving "koji-search-containers" into
the koji-containerbuild-cli
package:https://github.com/containerbuildsystem/koji-containerbuild/issue...
. There, again, I potentially would be adding a lot more code into a
single Python file (cli_containerbuild.py), and I would feel a lot
better if that was split up into multiple smaller files.
- Ken