[kmod/f21] Backport patch to fix device node permissions (rhbz 1147248)
by Josh Boyer
commit 722e0ca440d3f10fe0fd99102b8c49b59887a361
Author: Josh Boyer <jwboyer(a)fedoraproject.org>
Date: Wed Oct 29 14:07:48 2014 -0400
Backport patch to fix device node permissions (rhbz 1147248)
...s-indicate-that-creation-of-static-nodes-.patch | 36 ++++++++++++++++++++
kmod.spec | 8 ++++-
2 files changed, 43 insertions(+), 1 deletions(-)
---
diff --git a/0001-static-nodes-indicate-that-creation-of-static-nodes-.patch b/0001-static-nodes-indicate-that-creation-of-static-nodes-.patch
new file mode 100644
index 0000000..f8cb8f7
--- /dev/null
+++ b/0001-static-nodes-indicate-that-creation-of-static-nodes-.patch
@@ -0,0 +1,36 @@
+From 27eceb2e4ecbf2e31940b67cee682a6935f61e6c Mon Sep 17 00:00:00 2001
+From: Tom Gundersen <teg(a)jklm.no>
+Date: Mon, 27 Oct 2014 17:55:03 +0100
+Subject: [PATCH] static-nodes: indicate that creation of static nodes should
+ only happen at boot
+
+udev will only manage static nodes that exist at the time udev is started, so
+creating static nodes later on will likely not behave as expected. In
+particular, recreating the static nodes at run-time will reset any permissions
+udev may have applied to the nodes at boot.
+
+See <https://bugzilla.redhat.com/show_bug.cgi?id=1147248> and the discussion
+following <http://permalink.gmane.org/gmane.comp.sysutils.systemd.devel/23795>.
+
+Note that this requires (the yet to be released) systemd v217 or a backport
+of systemd patch 8c94052ee543c3598a3c7b0c46688150aa2c6168.
+---
+ tools/static-nodes.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tools/static-nodes.c b/tools/static-nodes.c
+index d1e3b6e..8d2356d 100644
+--- a/tools/static-nodes.c
++++ b/tools/static-nodes.c
+@@ -96,7 +96,7 @@ static int write_tmpfiles(FILE *out, char modname[], char devname[], char type,
+ return EXIT_FAILURE;
+ }
+
+- ret = fprintf(out, "%c /dev/%s 0600 - - - %u:%u\n",
++ ret = fprintf(out, "%c! /dev/%s 0600 - - - %u:%u\n",
+ type, devname, maj, min);
+ if (ret < 0)
+ return EXIT_FAILURE;
+--
+1.9.3
+
diff --git a/kmod.spec b/kmod.spec
index 77efb88..5a5075c 100644
--- a/kmod.spec
+++ b/kmod.spec
@@ -1,6 +1,6 @@
Name: kmod
Version: 18
-Release: 3%{?dist}
+Release: 4%{?dist}
Summary: Linux kernel module management utilities
Group: System Environment/Kernel
@@ -22,6 +22,8 @@ Provides: module-init-tools = 4.0-1
Obsoletes: module-init-tools < 4.0-1
Provides: /sbin/modprobe
+Patch1: 0001-static-nodes-indicate-that-creation-of-static-nodes-.patch
+
%description
The kmod package provides various programs needed for automatic
loading and unloading of modules under 2.6, 3.x, and later kernels, as well
@@ -48,6 +50,7 @@ applications that wish to load or unload Linux kernel modules.
%prep
%setup -q
+%patch1 -p1
%build
export V=1
@@ -111,6 +114,9 @@ install -m 755 %{SOURCE1} $RPM_BUILD_ROOT%{_sbindir}/weak-modules
%{_libdir}/libkmod.so
%changelog
+* Wed Oct 29 2014 Josh Boyer <jwboyer(a)fedoraproject.org> - 18-4
+- Backport patch to fix device node permissions (rhbz 1147248)
+
* Sun Aug 17 2014 Fedora Release Engineering <rel-eng(a)lists.fedoraproject.org> - 18-3
- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild
9 years, 6 months
[kmod/f20] Backport patch to fix device node permissions (rhbz 1147248)
by Josh Boyer
commit c2248d04d25cd0e03edfc39e5ba4d9aa969aa54e
Author: Josh Boyer <jwboyer(a)fedoraproject.org>
Date: Wed Oct 29 14:07:48 2014 -0400
Backport patch to fix device node permissions (rhbz 1147248)
...s-indicate-that-creation-of-static-nodes-.patch | 36 ++++++++++++++++++++
kmod.spec | 8 ++++-
2 files changed, 43 insertions(+), 1 deletions(-)
---
diff --git a/0001-static-nodes-indicate-that-creation-of-static-nodes-.patch b/0001-static-nodes-indicate-that-creation-of-static-nodes-.patch
new file mode 100644
index 0000000..f8cb8f7
--- /dev/null
+++ b/0001-static-nodes-indicate-that-creation-of-static-nodes-.patch
@@ -0,0 +1,36 @@
+From 27eceb2e4ecbf2e31940b67cee682a6935f61e6c Mon Sep 17 00:00:00 2001
+From: Tom Gundersen <teg(a)jklm.no>
+Date: Mon, 27 Oct 2014 17:55:03 +0100
+Subject: [PATCH] static-nodes: indicate that creation of static nodes should
+ only happen at boot
+
+udev will only manage static nodes that exist at the time udev is started, so
+creating static nodes later on will likely not behave as expected. In
+particular, recreating the static nodes at run-time will reset any permissions
+udev may have applied to the nodes at boot.
+
+See <https://bugzilla.redhat.com/show_bug.cgi?id=1147248> and the discussion
+following <http://permalink.gmane.org/gmane.comp.sysutils.systemd.devel/23795>.
+
+Note that this requires (the yet to be released) systemd v217 or a backport
+of systemd patch 8c94052ee543c3598a3c7b0c46688150aa2c6168.
+---
+ tools/static-nodes.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tools/static-nodes.c b/tools/static-nodes.c
+index d1e3b6e..8d2356d 100644
+--- a/tools/static-nodes.c
++++ b/tools/static-nodes.c
+@@ -96,7 +96,7 @@ static int write_tmpfiles(FILE *out, char modname[], char devname[], char type,
+ return EXIT_FAILURE;
+ }
+
+- ret = fprintf(out, "%c /dev/%s 0600 - - - %u:%u\n",
++ ret = fprintf(out, "%c! /dev/%s 0600 - - - %u:%u\n",
+ type, devname, maj, min);
+ if (ret < 0)
+ return EXIT_FAILURE;
+--
+1.9.3
+
diff --git a/kmod.spec b/kmod.spec
index 748b157..e2aef2f 100644
--- a/kmod.spec
+++ b/kmod.spec
@@ -1,6 +1,6 @@
Name: kmod
Version: 15
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: Linux kernel module management utilities
Group: System Environment/Kernel
@@ -22,6 +22,8 @@ Provides: module-init-tools = 4.0-1
Obsoletes: module-init-tools < 4.0-1
Provides: /sbin/modprobe
+Patch1: 0001-static-nodes-indicate-that-creation-of-static-nodes-.patch
+
%description
The kmod package provides various programs needed for automatic
loading and unloading of modules under 2.6, 3.x, and later kernels, as well
@@ -48,6 +50,7 @@ applications that wish to load or unload Linux kernel modules.
%prep
%setup -q
+%patch1 -p1
%build
export V=1
@@ -109,6 +112,9 @@ install -m 755 %{SOURCE1} $RPM_BUILD_ROOT%{_sbindir}/weak-modules
%{_libdir}/libkmod.so
%changelog
+* Wed Oct 29 2014 Josh Boyer <jwboyer(a)fedoraproject.org> - 15-2
+- Backport patch to fix device node permissions (rhbz 1147248)
+
* Thu Aug 22 2013 Josh Boyer <jwboyer(a)fedoraproject.org> - 15-1
- Update to version 15
9 years, 6 months
[Bug 1147248] systemd package update changes permissions in /dev
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1147248
--- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
(In reply to Josh Boyer from comment #5)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> > (In reply to Josh Boyer from comment #3)
> > > Is Fedora 20 going to get systemd v217? Because if not, I don't see the
> > > point in backporting the kmod fix. And if not, then is there something
> > > systemd should revert so that F20 is actually fixed?
> > F20 is not going to get systemd-217 because it's too big of a change. But it
> > gets some backported patches, this one will be included.
>
> Do you have a timeframe?
Should be tonight.
> The fixed systemd and kmod packages should be
> bundled in the same update in Bodhi so this isn't broken/fixed piecemeal.
Yes...
> I can do the backport of that single patch and build it, and then perhaps
> just reassign this bug to systemd so those maintainers can create the bodhi
> update?
...but I can't do the update afaik, because I'm neither maintainer for kmod nor
proven packager. Somebody else will have to do the update.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
9 years, 6 months
[Bug 1147248] systemd package update changes permissions in /dev
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1147248
--- Comment #5 from Josh Boyer <jwboyer(a)redhat.com> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> (In reply to Josh Boyer from comment #3)
> > Is Fedora 20 going to get systemd v217? Because if not, I don't see the
> > point in backporting the kmod fix. And if not, then is there something
> > systemd should revert so that F20 is actually fixed?
> F20 is not going to get systemd-217 because it's too big of a change. But it
> gets some backported patches, this one will be included.
Do you have a timeframe? The fixed systemd and kmod packages should be bundled
in the same update in Bodhi so this isn't broken/fixed piecemeal.
I can do the backport of that single patch and build it, and then perhaps just
reassign this bug to systemd so those maintainers can create the bodhi update?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
9 years, 6 months
[Bug 1147248] systemd package update changes permissions in /dev
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1147248
--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
(In reply to Josh Boyer from comment #3)
> Is Fedora 20 going to get systemd v217? Because if not, I don't see the
> point in backporting the kmod fix. And if not, then is there something
> systemd should revert so that F20 is actually fixed?
F20 is not going to get systemd-217 because it's too big of a change. But it
gets some backported patches, this one will be included.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
9 years, 6 months
[Bug 634736] sysctl.conf / sysctl.conf.d settings not read when modules are loaded
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=634736
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Fixed In Version| |initscripts-9.56.1-2.fc21
Resolution|--- |ERRATA
Last Closed| |2014-10-28 17:49:15
--- Comment #38 from Fedora Update System <updates(a)fedoraproject.org> ---
initscripts-9.56.1-2.fc21, systemd-216-5.fc21 has been pushed to the Fedora 21
stable repository. If problems still persist, please make note of it in this
bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
9 years, 6 months