On 08/05/14 at 08:38am, Vivek Goyal wrote:
On Tue, Aug 05, 2014 at 01:31:07PM +0800, WANG Chao wrote:
> This is about handling the shutdown path in kdump boot, including two small
> As Vivek suggested, systemd now will take care of the reboot/poweroff/halt and
> also unmount everything (including dump target). It's like what a normal boot
> does, and among all the advantanges, at least we don't have to worry about the
> data sync issue any more. systemd would do all that for us.
> Any objection to this switch?
I am fine with this change. Only downside I can think of is OOM situation.
It might happen that reboot might not work in low memory situation.
I think it's more likely to kill makedumpfile or dhclient (ssh/nfs case)
or some tasks with a high oom-killer score. I wouldn't worry too much
about error handler being killed. Anyway let's see.
Thanks for review!