On 02/05/15 at 01:26pm, Dave Young wrote:
Hi, Baoquan
On 02/03/15 at 03:35pm, Baoquan He wrote:
> Someone complains that kdump_post script doesn't execute after mount
> failed. This happened since mount failure will trigger
> kdump-error-handler.service, and then start kdump-error-handler.sh.
> However in kdump-error-handler.sh it doesn't execute kdump_post.
> Hence add it in this patch.
>
> Surely the function do_kdump_post need be moved into kdump-lib-initramfs.sh
> to be a common function.
>
> Signed-off-by: Baoquan He <bhe(a)redhat.com>
> ---
> dracut-kdump-error-handler.sh | 1 +
> dracut-kdump.sh | 7 -------
> kdump-lib-initramfs.sh | 7 +++++++
> 3 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/dracut-kdump-error-handler.sh b/dracut-kdump-error-handler.sh
> index 2f0f1d1..c4372dc 100755
> --- a/dracut-kdump-error-handler.sh
> +++ b/dracut-kdump-error-handler.sh
> @@ -7,4 +7,5 @@ export PATH=$PATH:$KDUMP_SCRIPT_DIR
>
> get_kdump_confs
> do_default_action
> +do_kdump_post
kdump post accepts an return value from dump function do_dump, because this is
in error handler so maybe pass an fake error number to do_kdump_post should
be ok.
I am fine with it, can repost to add this. Personally I think there's
no need to do this. Whatever it got it doesn't matter.
> do_final_action
> diff --git a/dracut-kdump.sh b/dracut-kdump.sh
> index e062665..fa8908f 100755
> --- a/dracut-kdump.sh
> +++ b/dracut-kdump.sh
> @@ -35,13 +35,6 @@ do_kdump_pre()
> fi
> }
>
> -do_kdump_post()
> -{
> - if [ -n "$KDUMP_POST" ]; then
> - "$KDUMP_POST" "$1"
> - fi
> -}
> -
> add_dump_code()
> {
> DUMP_INSTRUCTION=$1
> diff --git a/kdump-lib-initramfs.sh b/kdump-lib-initramfs.sh
> index 57b8304..9f26f6c 100755
> --- a/kdump-lib-initramfs.sh
> +++ b/kdump-lib-initramfs.sh
> @@ -161,3 +161,10 @@ do_final_action()
> {
> eval $FINAL_ACTION
> }
> +
> +do_kdump_post()
> +{
> + if [ -n "$KDUMP_POST" ]; then
> + "$KDUMP_POST" "$1"
> + fi
> +}
> --
> 1.8.5.3
>
> _______________________________________________
> kexec mailing list
> kexec(a)lists.fedoraproject.org
>
https://lists.fedoraproject.org/mailman/listinfo/kexec
>
>