On 10/14/14 at 11:46am, Vivek Goyal wrote:
On Tue, Oct 14, 2014 at 01:14:28PM +0800, WANG Chao wrote:
> It turns out that eppic_makedumpfile.so is dlopen()'d in makedumpfile.
> We don't need to ship this library in a separate subpackage.
>
Hi Chao,
I think we need to provide better changelog here. If makedumpfile does
dlopen() on eppic_makedumpfile.so, that does not enforce any choice. One
could either ship it in kexec-tools package or in a subpackage. Both
will work.
I think real reason was that code for eppic_makedumpfile.so
(extension_eppic.c) and some eppic scripts are in upstream makedumpfile
project. And that project is distributed as part of kexec-tools package.
Now breaking down that makedumpfile in two parts and shipping all
eppic specific bits in a separate subpackage was creating confusion
everytime we did some changes.
So to avoid that confusion and to keep all of the makedumpfile related
bits in a single package, this change is being done.
That's really better. Thanks.
I'll put these lines into the changelog.
Thanks
Vivek
> Now remove this package and put eppic_makedumpfile.so and its sample
> scripts in kexec-tools package.
>
> Signed-off-by: WANG Chao <chaowang(a)redhat.com>
> ---
> kexec-tools.spec | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/kexec-tools.spec b/kexec-tools.spec
> index dcfcd43..8db0acb 100644
> --- a/kexec-tools.spec
> +++ b/kexec-tools.spec
> @@ -86,18 +86,6 @@ normal or a panic reboot. This package contains the /sbin/kexec
> binary and ancillary utilities that together form the userspace
> component of the kernel's kexec feature.
>
> -%ifarch %{ix86} x86_64 ppc64 s390x ppc64le
> -%package eppic
> -Requires: %{name} = %{version}-%{release}
> -Summary: Additional eppic_makedumpfile.so shared object
> -Group: Applications/System
> -
> -%description eppic
> -The eppic_makedumpfile.so shared object is loaded by the
> -"makedumpfile --eppic" option, and is used to erase sensitive
> -or confidential kernel data from a dumpfile.
> -%endif
> -
> %package anaconda-addon
> Summary: Kdump configuration anaconda addon
> Requires: anaconda >= 21.33
> @@ -306,12 +294,8 @@ done
> %doc TODO
> %doc kexec-kdump-howto.txt
> %doc kdump-in-cluster-environment.txt
> -
> -%ifarch %{ix86} x86_64 ppc64 s390x ppc64le
> -%files eppic
> %{_libdir}/eppic_makedumpfile.so
> /usr/share/makedumpfile/eppic_scripts/
> -%endif
>
> %files anaconda-addon -f kdump-anaconda-addon.lang
> %{_datadir}/anaconda/addons/com_redhat_kdump
> --
> 1.9.3
>
> _______________________________________________
> kexec mailing list
> kexec(a)lists.fedoraproject.org
>
https://lists.fedoraproject.org/mailman/listinfo/kexec