On 05/25/22 at 09:47pm, John Donnelly wrote:
> On 3/23/22 03:17, Baoquan He wrote:
> > On 03/22/22 at 10:05pm, john.p.donnelly(a)oracle.com wrote:
> >
> > > Hi
> >
> > > There is a bug in
/lib/kdump/kdump-lib.sh when there are LVM crypto volumes
> > > on the system :
> >
> >
> > > Provisioning during the installation. In this
case lvm pool is created:
> > > # lvdisplay
> > > --- Logical volume ---
> > > LV Name pool00
> > > VG Name ol
> > > LV UUID LARWgk-Fgdq-naoV-R2eN-ooWQ-mcIF-N34LbR
> > > LV Write Access read/write (activated read only)
> > > LV Creation host, time localhost, 2021-11-16 14:06:22 -0500
> > > LV Pool metadata pool00_tmeta
> > > LV Pool data pool00_tdata
> > > LV Status available
> > > # open 0
> > > LV Size <20.15 GiB
> > > Allocated pool data 27.26%
> > > Allocated metadata 21.96%
> > > Current LE 5158
> > > Segments 1
> > > Allocation inherit
> > > Read ahead sectors auto
> > > - currently set to 8192
> > > Block device 252:5
> >
> >
> >
> >
> # kdumpctl rebuild
> > > kdump: Rebuilding /boot/initramfs-86_64kdump.img
> >
> >
> > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax
error near unexpected token
> > > `;'
> > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near unexpected
token
> > > `;'
> > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near unexpected
token
> > > `;'
> > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> >
> >
> >
> >
> > > # blkid -u filesystem,crypto -o export --
/dev/block/253:0
> > > DEVNAME=/dev/block/253:0
> > > UUID=a5ff3f28-3a29-4353-9a12-2c39e2b6d399
> > > TYPE=ext4
> >
> > > kexec-tools]# eval
"$(blkid -u filesystem,crypto -o export
> > > -- /dev/block/253:0); echo \$TYPE"
> > > ext4
> >
> > > [ kexec-tools]# blkid
-u filesystem,crypto -o export --
> > > /dev/block/11:0
> > > [root@ca-ostest469 kexec-tools]# eval "$(blkid -u filesystem,crypto
-o
> > > export
> > > -- /dev/block/11:0); echo \$TYPE"
> >
> > > bash: syntax error
near unexpected token `;'
> >
> > > so the error is seen
if blkid is not able to extract information from block
> > > device
> >
> >
> > > The fix :
> >
> >
> >
> >
> Applying this patch will avoid printing the error message.
> >
> > > ---
kdump-lib.sh.org
2022-02-03 17:23:48.654000000 -0600
> > > +++ kdump-lib.sh 2022-02-03 17:25:53.962000000 -0600
> > > @@ -936,6 +936,13 @@
> > > {
> > > [[ -b /dev/block/$1 ]] || return 1
> >
> > > + # If the given
device is LVM private, skip.
> > > + blkid -u filesystem,crypto -o export -- /dev/block/$1 > /dev/null
> > > + if [ $? -ne 0 ]
> > > + then
> > > + return 1
> > > + fi
> > > +
> > > local _type=$(eval "$(blkid -u filesystem,crypto -o export --
> > > /dev/block/$1); echo \$TYPE")
> > > [[ $_type == "crypto_LUKS" ]] && echo $1
> >
> >
> >
> >
> > > It is a non-fatal error. kdumpclt rebuild still
works.
> >
> > > Is there a upstream
github for this ? Or a contact you can share ?
>
> > This is the mailing list where kexec-tools package is
maintianed. You
> > can subscribe, send your problem description and finding, our colleages
> > may check it.
>
> > kexec(a)lists.fedoraproject.org
>
> > By the way, John, are you working on kexec/kdump
maintaining in Oracle
> > linux distros?
>
> Hi,
> This appears to be a dead list . No one ever replies and I
can't find it at
> :
>
https://accounts.fedoraproject.org/groups/
> ...
> Your mail to
'kexec(a)lists.fedoraproject.org' with the subject
> Re: Bug in lib/kdump/kdump-lib.sh ... on LVM crypto
volumes
> Is being held until the list moderator can review it for
approval.
You subscribed to the list, and got no response?
Hi Dave,
Do you know who is the moderator of the kexec fedora list?
Both Dave and me are the moderators. John haven't subscribed to the
mailing list which is why the message is hold. I've accepted his message
now. But I suggest John to join the mailing list via [1] since there are
too man spam emails and only allowing a member to post an email seems to
be the only way.
[1]