slub_debug parameter enables debug for slub, making each object take more memory than normal. During a typical kdump, "slub_debug=FZPU" will cost about 33MB additional memory. If users really want to enable this parameter, they should specify it in KDUMP_COMMANDLINE_APPEND.
Signed-off-by: Dangyi Liu dliu@redhat.com --- kdumpctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdumpctl b/kdumpctl index eaf7f67..9f7e56b 100755 --- a/kdumpctl +++ b/kdumpctl @@ -105,7 +105,7 @@ prepare_cmdline() else cmdline=${KDUMP_COMMANDLINE} fi - cmdline=`remove_cmdline_param "$cmdline" crashkernel hugepages hugepagesz panic_on_warn` + cmdline=`remove_cmdline_param "$cmdline" crashkernel hugepages hugepagesz panic_on_warn slub_debug`
cmdline="${cmdline} ${KDUMP_COMMANDLINE_APPEND}"
On 08/21/15 at 04:00pm, Dangyi Liu wrote:
slub_debug parameter enables debug for slub, making each object take more memory than normal. During a typical kdump, "slub_debug=FZPU" will cost about 33MB additional memory. If users really want to enable this parameter, they should specify it in KDUMP_COMMANDLINE_APPEND.
Signed-off-by: Dangyi Liu dliu@redhat.com
kdumpctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdumpctl b/kdumpctl index eaf7f67..9f7e56b 100755 --- a/kdumpctl +++ b/kdumpctl @@ -105,7 +105,7 @@ prepare_cmdline() else cmdline=${KDUMP_COMMANDLINE} fi
- cmdline=`remove_cmdline_param "$cmdline" crashkernel hugepages hugepagesz panic_on_warn`
- cmdline=`remove_cmdline_param "$cmdline" crashkernel hugepages hugepagesz panic_on_warn slub_debug`
The patch looks good to me, ack it.
Acked-by: Baoquan He bhe@redhat.com
Thanks Baoquan
On 08/21/15 at 04:00pm, Dangyi Liu wrote:
slub_debug parameter enables debug for slub, making each object take more memory than normal. During a typical kdump, "slub_debug=FZPU" will cost about 33MB additional memory. If users really want to enable this parameter, they should specify it in KDUMP_COMMANDLINE_APPEND.
Signed-off-by: Dangyi Liu dliu@redhat.com
kdumpctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdumpctl b/kdumpctl index eaf7f67..9f7e56b 100755 --- a/kdumpctl +++ b/kdumpctl @@ -105,7 +105,7 @@ prepare_cmdline() else cmdline=${KDUMP_COMMANDLINE} fi
- cmdline=`remove_cmdline_param "$cmdline" crashkernel hugepages hugepagesz panic_on_warn`
cmdline=`remove_cmdline_param "$cmdline" crashkernel hugepages hugepagesz panic_on_warn slub_debug`
cmdline="${cmdline} ${KDUMP_COMMANDLINE_APPEND}"
-- 2.4.3
It looks good to me.
Acked-by: Minfei Huang mhuang@redhat.com
Thanks for your effort on OOM relevant issue.
Thanks Minfei
On 08/21/15 at 04:00pm, Dangyi Liu wrote:
slub_debug parameter enables debug for slub, making each object take more memory than normal. During a typical kdump, "slub_debug=FZPU" will cost about 33MB additional memory. If users really want to enable this parameter, they should specify it in KDUMP_COMMANDLINE_APPEND.
Signed-off-by: Dangyi Liu dliu@redhat.com
kdumpctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdumpctl b/kdumpctl index eaf7f67..9f7e56b 100755 --- a/kdumpctl +++ b/kdumpctl @@ -105,7 +105,7 @@ prepare_cmdline() else cmdline=${KDUMP_COMMANDLINE} fi
- cmdline=`remove_cmdline_param "$cmdline" crashkernel hugepages hugepagesz panic_on_warn`
cmdline=`remove_cmdline_param "$cmdline" crashkernel hugepages hugepagesz panic_on_warn slub_debug`
cmdline="${cmdline} ${KDUMP_COMMANDLINE_APPEND}"
-- 2.4.3
kexec mailing list kexec@lists.fedoraproject.org https://lists.fedoraproject.org/mailman/listinfo/kexec
Good catch, ACK.
Thanks Dave
-
Baoquan He -
Dangyi Liu -
Dave Young -
Minfei Huang