"prot_virt" enables the kernel to run Secure Execution virtual machines on s390. These virtual machines are isolated from the hypervisor and thus protected against tampering by a malicious host. Enabling "prot_virt" requires a minimum of ~2.5GB memory which exceeds what is typically reserved for the crashkernel. Thus remove "prot_virt" from the command line for the 2nd kernel to prevent it to run out-of-memory.
Signed-off-by: Philipp Rudo prudo@redhat.com ---
v1 -> v2: * Improve commit message
kdump.sysconfig.s390x | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdump.sysconfig.s390x b/kdump.sysconfig.s390x index 439e462..234cfe9 100644 --- a/kdump.sysconfig.s390x +++ b/kdump.sysconfig.s390x @@ -17,7 +17,7 @@ KDUMP_COMMANDLINE="" # This variable lets us remove arguments from the current kdump commandline # as taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline # NOTE: some arguments such as crashkernel will always be removed -KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet log_buf_len swiotlb vmcp_cma cma hugetlb_cma" +KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet log_buf_len swiotlb vmcp_cma cma hugetlb_cma prot_virt"
# This variable lets us append arguments to the current kdump commandline # after processed by KDUMP_COMMANDLINE_REMOVE
On 07/16/21 at 10:34am, Philipp Rudo wrote:
"prot_virt" enables the kernel to run Secure Execution virtual machines on s390. These virtual machines are isolated from the hypervisor and thus protected against tampering by a malicious host. Enabling "prot_virt" requires a minimum of ~2.5GB memory which exceeds what is typically reserved for the crashkernel. Thus remove "prot_virt" from the command line for the 2nd kernel to prevent it to run out-of-memory.
After discussion with Philipp and explanation given by him, this patch looks good to me, so ack the patch.
Acked-by: Baoquan He bhe@redhat.com
By the way, can we add the v1 discussion thread link to commit log when patch gets merged? Since I believe that link including Philipp's explanation is very helpful when people wants to know why the code need be changed.
Hi Kairui,
When you merge the patch, could you try to grab the link into the log?
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org/...
Thanks Baoquan
""
Signed-off-by: Philipp Rudo prudo@redhat.com
v1 -> v2:
- Improve commit message
kdump.sysconfig.s390x | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdump.sysconfig.s390x b/kdump.sysconfig.s390x index 439e462..234cfe9 100644 --- a/kdump.sysconfig.s390x +++ b/kdump.sysconfig.s390x @@ -17,7 +17,7 @@ KDUMP_COMMANDLINE="" # This variable lets us remove arguments from the current kdump commandline # as taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline # NOTE: some arguments such as crashkernel will always be removed -KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet log_buf_len swiotlb vmcp_cma cma hugetlb_cma" +KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet log_buf_len swiotlb vmcp_cma cma hugetlb_cma prot_virt"
# This variable lets us append arguments to the current kdump commandline
# after processed by KDUMP_COMMANDLINE_REMOVE
2.31.1
On Mon, Jul 19, 2021 at 5:23 PM Baoquan He bhe@redhat.com wrote:
On 07/16/21 at 10:34am, Philipp Rudo wrote:
"prot_virt" enables the kernel to run Secure Execution virtual machines on s390. These virtual machines are isolated from the hypervisor and thus protected against tampering by a malicious host. Enabling "prot_virt" requires a minimum of ~2.5GB memory which exceeds what is typically reserved for the crashkernel. Thus remove "prot_virt" from the command line for the 2nd kernel to prevent it to run out-of-memory.
After discussion with Philipp and explanation given by him, this patch looks good to me, so ack the patch.
Acked-by: Baoquan He bhe@redhat.com
By the way, can we add the v1 discussion thread link to commit log when patch gets merged? Since I believe that link including Philipp's explanation is very helpful when people wants to know why the code need be changed.
Hi Kairui,
When you merge the patch, could you try to grab the link into the log?
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org/...
Thanks Baoquan
Sure, merged with the link appended in the commit log.
-- Best Regards, Kairui Song
-
Baoquan He -
Kairui Song -
Philipp Rudo