Resolves: BZ1484945 https://bugzilla.redhat.com/show_bug.cgi?id=1484945
Currently the kdumpctl script doesn't handle whitespaces (including TABs) which might be there before an option name in the kdump.conf
This patch addresses this issue, by ensuring that the kdumpctl errors out in case it finds any stray space(s) or tab(s) before a option name.
Reported-by: Kenneth D'souza kdsouza@redhat.com Signed-off-by: Bhupesh Sharma bhsharma@redhat.com --- Changes since v1: ----------------- - Addressed review comments from Dave: - Removed redundant documentation from man page. - Used [:blank:] regex instead of [:space:] to capture leading whitespaces in front of the option names.
kdumpctl | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/kdumpctl b/kdumpctl index b7a3105026eb..98eb89b919ed 100755 --- a/kdumpctl +++ b/kdumpctl @@ -406,6 +406,13 @@ check_config() return 1 }
+ # Check if we have any leading spaces (or tabs) before the + # variable name in the kdump conf file + if grep '^[[:blank:]]' $KDUMP_CONFIG_FILE; then + echo "No whitespaces are allowed before a kdump option name." + return 1 + fi + while read config_opt config_val; do case "$config_opt" in #* | "")
On 08/25/17 at 04:19pm, Bhupesh Sharma wrote:
Resolves: BZ1484945 https://bugzilla.redhat.com/show_bug.cgi?id=1484945
Currently the kdumpctl script doesn't handle whitespaces (including TABs) which might be there before an option name in the kdump.conf
This patch addresses this issue, by ensuring that the kdumpctl errors out in case it finds any stray space(s) or tab(s) before a option name.
Reported-by: Kenneth D'souza kdsouza@redhat.com Signed-off-by: Bhupesh Sharma bhsharma@redhat.com
Changes since v1:
- Addressed review comments from Dave:
- Removed redundant documentation from man page.
- Used [:blank:] regex instead of [:space:] to capture leading whitespaces in front of the option names.
kdumpctl | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/kdumpctl b/kdumpctl index b7a3105026eb..98eb89b919ed 100755 --- a/kdumpctl +++ b/kdumpctl @@ -406,6 +406,13 @@ check_config() return 1 }
- # Check if we have any leading spaces (or tabs) before the
- # variable name in the kdump conf file
- if grep '^[[:blank:]]' $KDUMP_CONFIG_FILE; then
This version still does not address the issue I mentioned about " #this is a comment" and " "
echo "No whitespaces are allowed before a kdump option name."
return 1
- fi
- while read config_opt config_val; do case "$config_opt" in #* | "")
-- 2.7.4