Some parameters need to be removed from the cmdline when kdump. These
include "quiet", "slub_debug", etc. This patch allows system admins
to
config what to remove, since they may use a different kernel.
What about some existing params? I think maybe "slub_debug" should also
be put here.
diff --git a/kdump.sysconfig b/kdump.sysconfig
index effe466..545228a 100644
--- a/kdump.sysconfig
+++ b/kdump.sysconfig
@@ -14,6 +14,11 @@ KDUMP_KERNELVER=""
# /proc/cmdline
KDUMP_COMMANDLINE=""
+# This variable lets us remove arguments from the current kdump commandline.
+# It's useful when KDUMP_COMMANDLINE is taken from /proc/cmdline and you want
+# to remove some of them.
+KDUMP_COMMANDLINE_REMOVE="quiet"
+
# This variable lets us append arguments to the current kdump commandline
# As taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline
KDUMP_COMMANDLINE_APPEND="irqpoll maxcpus=1 reset_devices"
diff --git a/kdump.sysconfig.i386 b/kdump.sysconfig.i386
index bb7a6e5..0a15cd0 100644
--- a/kdump.sysconfig.i386
+++ b/kdump.sysconfig.i386
@@ -14,6 +14,11 @@ KDUMP_KERNELVER=""
# /proc/cmdline
KDUMP_COMMANDLINE=""
+# This variable lets us remove arguments from the current kdump commandline.
+# It's useful when KDUMP_COMMANDLINE is taken from /proc/cmdline and you want
+# to remove some of them.
+KDUMP_COMMANDLINE_REMOVE="quiet"
+
# This variable lets us append arguments to the current kdump commandline
# As taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline
KDUMP_COMMANDLINE_APPEND="irqpoll nr_cpus=1 reset_devices numa=off
udev.children-max=2 panic=10 rootflags=nofail transparent_hugepage=never"
diff --git a/kdump.sysconfig.ppc64 b/kdump.sysconfig.ppc64
index dd09598..1188764 100644
--- a/kdump.sysconfig.ppc64
+++ b/kdump.sysconfig.ppc64
@@ -14,6 +14,11 @@ KDUMP_KERNELVER=""
# /proc/cmdline
KDUMP_COMMANDLINE=""
+# This variable lets us remove arguments from the current kdump commandline.
+# It's useful when KDUMP_COMMANDLINE is taken from /proc/cmdline and you want
+# to remove some of them.
+KDUMP_COMMANDLINE_REMOVE="quiet"
+
# This variable lets us append arguments to the current kdump commandline
# As taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline
KDUMP_COMMANDLINE_APPEND="irqpoll maxcpus=1 noirqdistrib reset_devices
cgroup_disable=memory numa=off udev.children-max=2 ehea.use_mcs=0 panic=10
rootflags=nofail kvm_cma_resv_ratio=0 transparent_hugepage=never"
diff --git a/kdump.sysconfig.ppc64le b/kdump.sysconfig.ppc64le
index dd09598..1188764 100644
--- a/kdump.sysconfig.ppc64le
+++ b/kdump.sysconfig.ppc64le
@@ -14,6 +14,11 @@ KDUMP_KERNELVER=""
# /proc/cmdline
KDUMP_COMMANDLINE=""
+# This variable lets us remove arguments from the current kdump commandline.
+# It's useful when KDUMP_COMMANDLINE is taken from /proc/cmdline and you want
+# to remove some of them.
+KDUMP_COMMANDLINE_REMOVE="quiet"
+
# This variable lets us append arguments to the current kdump commandline
# As taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline
KDUMP_COMMANDLINE_APPEND="irqpoll maxcpus=1 noirqdistrib reset_devices
cgroup_disable=memory numa=off udev.children-max=2 ehea.use_mcs=0 panic=10
rootflags=nofail kvm_cma_resv_ratio=0 transparent_hugepage=never"
diff --git a/kdump.sysconfig.s390x b/kdump.sysconfig.s390x
index b103a88..1981999 100644
--- a/kdump.sysconfig.s390x
+++ b/kdump.sysconfig.s390x
@@ -14,6 +14,11 @@ KDUMP_KERNELVER=""
# /proc/cmdline
KDUMP_COMMANDLINE=""
+# This variable lets us remove arguments from the current kdump commandline.
+# It's useful when KDUMP_COMMANDLINE is taken from /proc/cmdline and you want
+# to remove some of them.
+KDUMP_COMMANDLINE_REMOVE="quiet"
+
# This variable lets us append arguments to the current kdump commandline
# As taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline
KDUMP_COMMANDLINE_APPEND="nr_cpus=1 cgroup_disable=memory numa=off
udev.children-max=2 panic=10 rootflags=nofail transparent_hugepage=never"
diff --git a/kdump.sysconfig.x86_64 b/kdump.sysconfig.x86_64
index 7991d68..bf7b974 100644
--- a/kdump.sysconfig.x86_64
+++ b/kdump.sysconfig.x86_64
@@ -14,6 +14,11 @@ KDUMP_KERNELVER=""
# /proc/cmdline
KDUMP_COMMANDLINE=""
+# This variable lets us remove arguments from the current kdump commandline.
+# It's useful when KDUMP_COMMANDLINE is taken from /proc/cmdline and you want
+# to remove some of them.
+KDUMP_COMMANDLINE_REMOVE="quiet"
+
# This variable lets us append arguments to the current kdump commandline
# As taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline
KDUMP_COMMANDLINE_APPEND="irqpoll nr_cpus=1 reset_devices cgroup_disable=memory
mce=off numa=off udev.children-max=2 panic=10 rootflags=nofail acpi_no_memhotplug
transparent_hugepage=never"
diff --git a/kdumpctl b/kdumpctl
index 9f7e56b..37ec3ab 100755
--- a/kdumpctl
+++ b/kdumpctl
@@ -105,7 +105,7 @@ prepare_cmdline()
else
cmdline=${KDUMP_COMMANDLINE}
fi
- cmdline=`remove_cmdline_param "$cmdline" crashkernel hugepages hugepagesz
panic_on_warn slub_debug`
+ cmdline=`remove_cmdline_param "$cmdline" crashkernel hugepages hugepagesz
panic_on_warn slub_debug ${KDUMP_COMMANDLINE_REMOVE}`
cmdline="${cmdline} ${KDUMP_COMMANDLINE_APPEND}"
--
2.4.3
Show replies by date