Sent a V3 ignore this patch.
On Wed, Oct 10, 2018 at 2:30 PM, Kenneth Dsouza <kdsouza(a)redhat.com> wrote:
> From: Kenneth D'souza <kdsouza(a)redhat.com>
>
> Currently the script does not check if the dump target is read-only and would
> always mount to read-write mode. This caused an issue with nfs mount as
> the fstab options would be reconsidered while remounting to read-write mode.
> The remount would fail with the below error as all options cannot be changed
> runtime.
>
> mount.nfs: mount(2): Invalid argument
> mount.nfs: an incorrect mount option was specified
>
> Which in result would not save the vmcore on the dump target.
>
> This patch addresses this issue by checking the dump target status for read-only.
> If yes, remount to read-write mode without reconsidering the fstab options.
>
> Signed-off-by: Kenneth D'souza <kdsouza(a)redhat.com>
> ---
> kdump-lib-initramfs.sh | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kdump-lib-initramfs.sh b/kdump-lib-initramfs.sh
> index 2c18c87..bc74871 100755
> --- a/kdump-lib-initramfs.sh
> +++ b/kdump-lib-initramfs.sh
> @@ -87,6 +87,7 @@ dump_fs()
>
> local _dev=$(findmnt -k -f -n -r -o SOURCE $1)
> local _mp=$(findmnt -k -f -n -r -o TARGET $1)
> + local _op=$(findmnt -k -f -n -r -o OPTIONS $1)
>
> echo "kdump: dump target is $_dev"
>
> @@ -100,7 +101,13 @@ dump_fs()
>
> echo "kdump: saving to $_mp/$KDUMP_PATH/$HOST_IP-$DATEDIR/"
>
> - mount -o remount,rw $_mp || return 1
> + # Only remount to read-write mode if the dump target is mounted read-only.
> + check_status=$(echo $_op | grep -w rw)
> + if [ -z "$check_status" ]; then
> + echo "kdump: Mounting Dump target $_dev in rw mode."
> + mount -o remount,rw $dev $_mp || return 1
> + fi
> +
> mkdir -p $_mp/$KDUMP_PATH/$HOST_IP-$DATEDIR || return 1
>
> save_vmcore_dmesg_fs ${DMESG_COLLECTOR}
"$_mp/$KDUMP_PATH/$HOST_IP-$DATEDIR/"
> --
> 2.14.3
> _______________________________________________
> kexec mailing list -- kexec(a)lists.fedoraproject.org
> To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
https://getfedora.org/code-of-conduct.html
> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org