On Fri, Feb 14, 2014 at 10:28:51AM +0800, Dave Young wrote:
On 02/13/14 at 08:58am, Vivek Goyal wrote:
> On Thu, Feb 13, 2014 at 11:23:58AM +0800, Dave Young wrote:
>
> [..]
> > status)
> > EXIT_CODE=0
> > - status
> > + check_current_kdump_status
> > case "$?" in
> > 0)
> > echo "Kdump is operational"
> > @@ -638,10 +633,6 @@ main ()
> > echo "Kdump is not operational"
> > EXIT_CODE=3
> > ;;
> > - 2)
> > - echo "Kdump is unsupported on this kernel"
> > - EXIT_CODE=3
> > - ;;
>
> Dave this change looks good. What is EXIT_CODE=3? Who parses it and
> what's the significance of value 3?
Vivek, I have no idea about the EXIT_CODE, it probably a historic code..
Ok, following commit introduced it.
commit 10c91a1493d152da608c0e5fdc0ced79113229d5
Author: Neil Horman <nhorman(a)tuxdriver.com>
Date: Wed Jul 6 15:25:34 2011 -0400
Removing sysvinit files
I think this is a vestige of old init system. I have tried to read and
nowhere I can find if exit code 3 has special meaning.
I suspect that if we return 0 for success and 1 for failure, things
would be just fine.
If you like, post a patch for cleanup in Fedora. We can keep it in fedora
for some time and see if something breaks. I don't expect anything to
break though.
Thanks
Vivek