On 1/13/21 5:13 PM, Kairui Song wrote:
...
That commit is trying to workaround a kernel VFS bug. Now,
the VFS issue should have been fixed in all recent releases, so
remove this workaround.
This reverts commit 539bff40830e961d7ef85248e39bff0e40b23c91.
Signed-off-by: Kairui Song <kasong(a)redhat.com>;
---
mkdumprd | 3 ---
1 file changed, 3 deletions(-)
diff --git a/mkdumprd b/mkdumprd
index 0623940..8ba8e2a 100644
--- a/mkdumprd
+++ b/mkdumprd
@@ -86,9 +86,6 @@ to_mount() {
# drop nofail or nobootwait
_options=$(echo $_options | sed 's/\(^\|,\)nofail\($\|,\)/\1/g')
_options=$(echo $_options | sed 's/\(^\|,\)nobootwait\($\|,\)/\1/g')
- # use both nofail and x-systemd.before to ensure systemd will try best to
- # mount it before kdump starts, this is an attempt to improve robustness
- _options="$_options,nofail,x-systemd.before=initrd-fs.target"
echo "$_pdev $_new_mntpoint $_fstype $_options"
}
Acked-by: Pingfan Liu <piliu(a)redhat.com>
Just a note for downstream users, I think the revert is fine for
recent Fedora with systemd 245 or later, which includes this fix:
mount: mark an existing "mounting" unit from /proc/self/mountinfo as
"just_mounted"
https://github.com/systemd/systemd/commit/1d086a6e59729635396204fc05234f1...
However, deployment with older systemd still requires the workaround.
--
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.