On Thu, Jun 01, 2023 at 04:37:50PM +0800, Tao Liu wrote:

LGTM, thanks!

Reviewed-by: Tao Liu ltao@redhat.com

Thanks, the patch has been merged!

On Thu, Jun 1, 2023 at 4:31 PM Coiby Xu coxu@redhat.com wrote:

...

A space was added by mistake and unfortunately fips-mode-setup refuses an extra parameter,

# fips-mode-setup --is-enabled 2 > /dev/null
# echo $?
2
# fips-mode-setup --is-enabled 2
Check, enable, or disable the system FIPS mode.
usage: /usr/bin/fips-mode-setup --enable|--disable [--no-bootcfg]
usage: /usr/bin/fips-mode-setup --check
usage: /usr/bin/fips-mode-setup --is-enabled

So in this case mkdumprd can never detect if FIPS is enabled. Fix this mistake.

Fixes: 443a43e0 ("mkdumprd: call dracut with --add-device to install the drivers needed by /boot partition automatically for FIPS") Signed-off-by: Coiby Xu coxu@redhat.com

---

mkdumprd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkdumprd b/mkdumprd index 3932a1fd..f93874d3 100644 --- a/mkdumprd +++ b/mkdumprd @@ -464,7 +464,7 @@ if ! is_fadump_capable; then

    add_dracut_arg "--no-hostonly-default-device"

•   if fips-mode-setup --is-enabled 2 > /dev/null; then
  

•   if fips-mode-setup --is-enabled 2> /dev/null; then
            add_dracut_arg --add-device "$(findmnt -n -o SOURCE --target /boot)"
    fi
  

fi

2.40.1 _______________________________________________ kexec mailing list -- kexec@lists.fedoraproject.org To unsubscribe send an email to kexec-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue