drm modules have been causing many troubles and they often doesn't work and only consume extra memory in second kernel. And if failure shell is not enabled, they are not very useful either even if they works. So drop it by default and add some comment to allow user add it back if really needed.
Kairui Song (2): Drop drm modules if failure_action is not shell kdump.conf: Add some inline comment about drm module
dracut-module-setup.sh | 6 ++++-- kdump.conf | 6 +++++- 2 files changed, 9 insertions(+), 3 deletions(-)
drm drivers have been causing a lot of problems and in most case they are not very useful. So disable them if failure_action is not shell. For failure shell, drm drivers might be required for graphic console.
Signed-off-by: Kairui Song kasong@redhat.com --- dracut-module-setup.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh index 066d0ce..e81dee9 100755 --- a/dracut-module-setup.sh +++ b/dracut-module-setup.sh @@ -58,8 +58,10 @@ depends() { _dep="$_dep znet" fi
- if [ -n "$( ls -A /sys/class/drm 2>/dev/null )" ] || [ -d /sys/module/hyperv_fb ]; then - add_opt_module drm + if [[ $(get_option_value "failure_action") == "shell" ]]; then + if [ -n "$( ls -A /sys/class/drm 2>/dev/null )" ] || [ -d /sys/module/hyperv_fb ]; then + add_opt_module drm + fi fi
if is_generic_fence_kdump || is_pcs_fence_kdump; then
Now drm drivers are not included by default, if user want to see something on screen, dracut_args can be used. --- kdump.conf | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/kdump.conf b/kdump.conf index dea2e94..115b8ae 100644 --- a/kdump.conf +++ b/kdump.conf @@ -150,6 +150,10 @@ # # dracut_args <arg(s)> # - Pass extra dracut options when rebuilding kdump initrd. +# For example, for stability reason, drm drivers are not included +# in kdump initramfs by default unless 'failure_action' is 'shell'. +# If you want to see kdump progress on your graphic console, you +# may add '--add "drm"' here. # # fence_kdump_args <arg(s)> # - Command line arguments for fence_kdump_send (it can contain @@ -180,6 +184,6 @@ core_collector makedumpfile -l --message-level 7 -d 31 #failure_action shell #force_rebuild 1 #force_no_rebuild 1 -#dracut_args --omit-drivers "cfg80211 snd" --add-drivers "ext2 ext3" +#dracut_args --omit-drivers "cfg80211 snd" --add-drivers "ext2 ext3" --add "drm" #fence_kdump_args -p 7410 -f auto -c 0 -i 10 #fence_kdump_nodes node1 node2
-
Kairui Song