On Mon, 23 Aug 2021 09:14:24 +0800
lijiang <lijiang(a)redhat.com> wrote:
Thank you for the explanation, Philipp and Dave.
BTW: I will merge the 'wget/patch' patches into a single patch.
sure, the only reason I sent them separately was because I only
noticed the missing 'patch' after I sent out the first patch...
Acked-by: Lianbo Jiang <lijiang(a)redhat.com>
Thanks
Philipp
On Fri, Aug 20, 2021 at 7:05 PM Philipp Rudo <prudo(a)redhat.com> wrote:
> Hi Lianbo,
>
> On Fri, 20 Aug 2021 09:40:03 +0800
> lijiang <lijiang(a)redhat.com> wrote:
>
> > On Wed, Aug 18, 2021 at 10:30 PM Philipp Rudo <prudo(a)redhat.com> wrote:
> >
> > > wget is used to download the tar ball with the gdb sources. Add it as a
> > > build requirement.
> > >
> >
> > Thank you for the patch, Philipp.
> >
> > It looks reasonable, but I have never reproduced this issue on
> > kojibuild(the wget/patch packages may have been installed in the
> kojibuild
> > environment by default),
> > are you using the 'fedpkg local' to build the packages and reproduce
this
> > issue?
>
> no, I simply used a fresh F34 Server install from beaker, ran dnf
> builddep and then tried to compile the current upstream. This failed
> due to the missing wget and patch.
>
> Thanks
> Philipp
>
> >
> > Thanks.
> > Lianbo
> >
> >
> > > Signed-off-by: Philipp Rudo <prudo(a)redhat.com>
> > > ---
> > > crash.spec | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/crash.spec b/crash.spec
> > > index 212d3c8..cd42075 100644
> > > --- a/crash.spec
> > > +++ b/crash.spec
> > > @@ -11,7 +11,7 @@ Source1:
http://ftp.gnu.org/gnu/gdb/gdb-7.6.tar.gz
> > > URL:
https://crash-utility.github.io
> > > ExclusiveOS: Linux
> > > ExclusiveArch: %{ix86} ia64 x86_64 ppc ppc64 s390 s390x %{arm} aarch64
> > > ppc64le
> > > -BuildRequires: ncurses-devel zlib-devel lzo-devel snappy-devel bison
> > > +BuildRequires: ncurses-devel zlib-devel lzo-devel snappy-devel bison
> wget
> > > BuildRequires: gcc gcc-c++
> > > BuildRequires: make
> > > Requires: binutils
> > > --
> > > 2.31.1
> > >
> > >
>
>