On 06/05/2016:10:58:06 AM, Baoquan He wrote:
On 05/05/16 at 05:20pm, Pratyush Anand wrote:
> When $KDUMP_BOOTDIR is RO then kexec-tools should not try rebuild initramfs
> even when conditions for rebuild is met.
This is a really good catch, ack it.
Acked-by: Baoquan He <bhe(a)redhat.com>
Thanks..
I think, I screwed up while sending patches. This patch was not part of current
series.
It was already acked by Dave when I had sent it last time.
~Pratyush
>
>
> >
> > Signed-off-by: Pratyush Anand <panand(a)redhat.com>
> > ---
> > kdumpctl | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/kdumpctl b/kdumpctl
> > index ef18a2d4f6ce..8ec6b2de914b 100755
> > --- a/kdumpctl
> > +++ b/kdumpctl
> > @@ -406,6 +406,11 @@ check_rebuild()
> > return 0
> > fi
> >
> > + if [[ ! -w "$KDUMP_BOOTDIR" ]];then
> > + echo "$KDUMP_BOOTDIR does not have write permission. Can not rebuild
$TARGET_INITRD"
> > + return 1
> > + fi
> > +
> > echo "Rebuilding $TARGET_INITRD"
> > rebuild_initrd
> > return $?
> > --
> > 2.5.5
> >