On 06/25/15 at 05:48pm, Minfei Huang wrote:
On 06/23/15 at 03:24pm, Dave Young wrote:
> > We shall take care of the hostname, since the result format is different
> > by command "/sbin/ip -6 route get to $_server".
> >
> > As you said, static route or other function may breake, if we do not
> > parse the hostname.
>
> But you said "ip route" will works for both ipv4 and ipv6, so we should
> leave "ip" tool to handle the different protocals, we should only change
> the kdump dev name what we pass to 2nd kernel with prefix kdump-
>
In my opinion, we can do a cleanup later, since this patchset passed the
testcase. And the cleanup does not break up code path, so I think it may
be better. Otherwise there are a lot of duplicate test work to do.
Sorry, I can not agree that adding more code in case you can add less. It is hard
to review. This is not the last version, you still need restructure the patches
shouldn't you retest them?
Thanks
Dave