On Mon, Nov 14, 2022 at 6:44 PM Philipp Rudo <prudo(a)redhat.com> wrote:
Hi Pingfang,
the patch looks good to me. One tiny nit, though.
On Wed, 9 Nov 2022 20:44:05 +0800
Pingfan Liu <piliu(a)redhat.com> wrote:
> This commit has the same motivation as the commit 677da8a "sysconfig:
> use a simple generator script to maintain".
>
> At present, only the kdump.conf generated for s390x has a slight
> difference from the other arches, where the core_collector asks the
> makedumpfile to use "-c" option to compress dump data by each page using
> zlib, which is more efficient than lzo on s390x.
>
> Signed-off-by: Pingfan Liu <piliu(a)redhat.com>
> ---
> gen-kdump-conf.sh | 232 ++++++++++++++++++++++++++++++++++++++++++++++
> kexec-tools.spec | 5 +-
You should remove the kdump.conf contained in the repo. It's no
longer used and will confuse people otherwise.
Sure. Thanks for your review. I will send out V2 immediately.