On Wed, Apr 02, 2014 at 12:11:15PM -0400, Martin Perina wrote:
----- Original Message -----
> From: "Vivek Goyal" <vgoyal(a)redhat.com>
> To: "Martin Perina" <mperina(a)redhat.com>
> Cc: kexec(a)lists.fedoraproject.org
> Sent: Wednesday, April 2, 2014 4:03:48 PM
> Subject: Re: [PATCH 7/7] Add fence_kdump support for generic clusters
>
> On Wed, Apr 02, 2014 at 10:33:47AM +0200, Martin Perina wrote:
>
> [..]
> > +# get_pcs_cluster_modified_files <image timestamp>
> > +# return list of modified file for fence_kdump modified in Pacemaker
> > cluster
> > +get_pcs_cluster_modified_files()
> > {
> > local image_time=$1
> > - local cib_time
> > + local time_stamp
> > + local modified_files
> >
> > + is_generic_fence_kdump && return 1
> > is_pcs_fence_kdump || return 1
>
> Do we need both the checks above? I thought one check should be suffice.
> Either check for generic cluster or check for pcs configuration.
If generic fence_kdump is configured, we don't want to process Pacemaker config
(as generic fence_kdump config takes precedence over Pacemaker fence_kdump).
And if Pacemaker fence_kdump is not configured, we also don't want to process
further.
Ok got it. If something is not generic fence kdump does not mean that
pacemaker is configured. So we need to check for both.
Thanks
Vivek