Kairui Song <ryncsn(a)gmail.com> 于2021年12月27日周一 13:06写道:
Hi Coiby and Tao
Coiby Xu <coxu(a)redhat.com> 于2021年12月27日周一 09:35写道:
>
> On Fri, Dec 24, 2021 at 05:32:35PM +0800, Tao Liu wrote:
> >Hi Coiby,
> >
> >On Thu, Dec 23, 2021 at 3:50 PM Coiby Xu <coxu(a)redhat.com> wrote:
> >>
> >> Hi Tao,
> >>
> >> Thanks for the patch!
> >>
> >> On Sat, Dec 18, 2021 at 04:14:44PM +0800, Tao Liu wrote:
> >> >For earlykdump, kdump-lib-initramfs.sh is sourced by kdump-lib.sh,
> >> >however it is not installed in dracut-early-kdump-module-setup.sh.
Same
> >> >as xargs, which is used by kdump-lib.sh. Otherwise earlykdump will
report
> >> >file not found errors.
> >>
> >> Should we install /usr/bin/xargs in dracut-module-setup.sh as well since
> >> it also sources kdump-lib.sh
> >>
> >I think it is not needed.
> >
> >As for earlykdump, kdump-lib.sh/xargs are used both for making
> >initramfs-kdump.img in 1st kernel, and the runtime in 2nd kernel, so
> >xargs/kdump-lib.sh must be installed in initramfs-kdump.img. However,
> >as for non-earlykdump, kdump-lib.sh/xargs are used only for making
> >initramfs-kdump.img in the 1st kernel, and can both be accessed
> >locally, needn't to be installed in initramfs-kdump.img for 2nd kernel
> >runtime use.
>
> Thanks for the explanation! Patch has been merged with a small change
> about the format of "Fixes:" tag,
>
> Fixes: a5faa052d4969cb66719d0b795d746449d3c71b7
> ("kdump-lib-initramfs.sh: prepare to be a POSIX compatible
lib")
> Fixes: 4f01cb1b0a4e1ea9467e9ace34d14dcb2fbe135a
> ("kdump-lib.sh: fix variable quoting issue")
>
A little suggestion, maybe just follow the Linux kernel commit format
will be a better idea, a full sha1 id is a bit too long.
Quote from linux kernel document:
"""
If your patch fixes a bug in a specific commit, e.g. you found an
issue using git bisect, please use the ‘Fixes:’ tag with the first 12
characters of the SHA-1 ID, and the one line summary. For example:
Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")
The following git config settings can be used to add a pretty format
for outputting the above style in the git log or git show commands:
[core]
abbrev = 12
[pretty]
fixes = Fixes: %h (\"%s\")
"""
Hmm, after a quick git log check, seems we have been using full sha1
id format in the past for quite several times, you can ignore my reply
then.