On 2016/05/23 at 16:40, Dave Young wrote:
Hi, Xunlei
Will review the patches, but a quick comment about the doc first.
It maybe not a good idea to advertise the --mount usage since it skips
kdump logic without any checking and setup. It can be a way to address
issues we do not support like the nfs-mount-before-build-kdump-initrd issue.
So how about only documenting it in howto.txt, and drop the kdump.conf and
manpage part.
Ok, I will update it after receiving more review.
Regards,
Xunlei
On 05/23/16 at 03:06pm, Xunlei Pang wrote:
> Update "kexec-kdump-howto", as well as "kdump.conf" and its man
page.
>
> Signed-off-by: Xunlei Pang <xlpang(a)redhat.com>
> ---
> kdump.conf | 17 +++++++++++++++++
> kdump.conf.5 | 17 +++++++++++++++++
> kexec-kdump-howto.txt | 21 +++++++++++++++++++++
> 3 files changed, 55 insertions(+)
>
> diff --git a/kdump.conf b/kdump.conf
> index 54b581d..ed20f71 100644
> --- a/kdump.conf
> +++ b/kdump.conf
> @@ -133,6 +133,23 @@
> # - Pass extra dracut options when rebuilding kdump
> # initrd.
> #
> +# Users can utilize this directive to pass "--mount" to kdump,
> +# please refer to "man dracut" for the format of "--mount"
argument.
> +# If there is any "--mount" specified via "dracut_args",
kdump
> +# always uses it as the final mount target without any validation
> +# (mounting or checking like mount options, fs size, save path, etc),
> +# so users are expected to ensure all its correctness. It conflicts
> +# with targets specified via "ext[234]/xfs/btrfs/nfs".
> +#
> +# As an nfs example:
> +# dracut_args --mount "192.168.1.1:/test test nfs
defaults,x-initrd.mount"
> +#
> +# NOTE:
> +# -Only one mount target is allowed using "dracut_args" globally.
> +# -Dracut will create <mountpoint> if it doesn't exist in kdump
kernel.
> +# -Users should do a test first and ensure it works because kdump does
> +# not prepare the mount and check all the validity.
> +#
> # fence_kdump_args <arg(s)>
> # - Command line arguments for fence_kdump_send (it can contain
> # all valid arguments except hosts to send notification to).
> diff --git a/kdump.conf.5 b/kdump.conf.5
> index f1c2a2c..7b5b0ba 100644
> --- a/kdump.conf.5
> +++ b/kdump.conf.5
> @@ -183,6 +183,23 @@ to try dumping. By default, it's set to 0, means not to try
a destined failure.
> .RS
> Kdump uses dracut to generate initramfs for second kernel. This option
> allows a user to pass arguments to dracut directly.
> +
> +Users can utilize this directive to pass "--mount" to kdump, please refer
> +to "man dracut" for the format of "--mount" argument. If there
is any
> +"--mount" specified via "dracut_args", kdump always uses it as
the final
> +mount target without any validation(mounting or checking like mount options,
> +fs size, save path, etc), so users are expected to ensure all the correctness.
> +It conflicts with targets specified via "ext[234]/xfs/btrfs/nfs".
> +
> +As an nfs example:
> +dracut_args --mount "192.168.1.1:/test test nfs defaults,x-initrd.mount"
> +
> +Note 1: Only one mount target is allowed using "dracut_args" globally.
> +
> +Note 2: Dracut will create <mountpoint> if it doesn't exist in kdump
kernel.
> +
> +Note 3: Users should do a test first and ensure it works because kdump does
> + not prepare the mount and check all the validity.
> .RE
>
>
> diff --git a/kexec-kdump-howto.txt b/kexec-kdump-howto.txt
> index b4cdc22..dde95c6 100644
> --- a/kexec-kdump-howto.txt
> +++ b/kexec-kdump-howto.txt
> @@ -345,6 +345,27 @@ mount the NFS mount and copy out the vmcore to your NFS server.
Restart the
> kdump service via '/sbin/systemctl restart kdump.service' to commit this
change
> to your kdump initrd.
>
> +Special mount via "dracut_args"
> +
> +Kdump uses dracut to generate initramfs for second kernel. This option
> +allows a user to pass arguments to dracut directly.
> +
> +Users can utilize "dracut_args" to pass "--mount" to kdump,
please refer
> +to "man dracut" for the format of "--mount" argument. If there
is any
> +"--mount" specified via "dracut_args", kdump always uses it as
the final
> +mount target without any validation(mounting or checking like mount options,
> +fs size, save path, etc), so users are expected to ensure all the correctness.
> +It conflicts with targets specified via "ext[234]/xfs/btrfs/nfs".
> +
> +As an nfs special mount example:
> +dracut_args --mount "192.168.1.1:/test test nfs defaults,x-initrd.mount"
> +
> +NOTE:
> +-Only one mount target is allowed using "dracut_args" globally.
> +-Dracut will create <mountpoint> if it doesn't exist in kdump kernel.
> +-Users should do a test first and ensure it works because kdump does
> + not prepare the mount and check all the validity.
> +
> Remote system via ssh/scp
>
> Dumping over ssh/scp requires setting up passwordless ssh keys for every
> --
> 1.8.3.1
>