On Tue, Jan 21, 2014 at 10:47:52PM +0530, Hari Bathini wrote:
This patch set implements firmware-assisted dump support for kdump
service. Firmware-assisted dump support depends on existing kdump
infrastructure (kdump scripts) present in userland to save dump
to the disk. Though existing kdump script will work seemlessly, it
still needs to modified to make it aware of presense of firmware-
assisted dump feature during service start and stop. These changes
are tested successfully on a power box with fedora19.
I have some general comments.
- Can you please write a .txt file say fadump-powerpc-howto.txt and put
some details about how fadump works, how to configure it etc. For
details you can refer to kernel Documentation/powerpc/fadump*.txt file.
I am more interested here in putting details about how initrd is
generated and managed etc.
- Please put details about how user can switch between kdump and fadump
- I did not see any code which does not reboot machine after capturing
- How would you handle "default" in kdump.conf. I think all these defaults
don't make sense in case of fadump? IOW, if dump capturing fails what
would you do? Continue normal boot?
IF yes, we need to put all these details in fadump howto file.
- If "default" are ignored in fadump mode, we might want to give a warning
to user about it.
- Are you still saving dump from initramfs context? Why?