Hi Tong Li,
Thanks for the cleanup.
On Tuesday 13 December 2016 09:52 AM, Tong Li wrote:
Didn't delete rhcrashkernel-param file in last version, resending it.
You need not mention justification of resend/V2 in commit log. In stead these can be mentioned after "---". You need to hand edit patch file.
Since currently crashkernel= will be handled in kdump anaconda addon
we can safely remove rhcrashkernel-param callback.
This should close
https://bugzilla.redhat.com/show_bug.cgi?id=1399436 .
Better to follow convention like:
Resolves: bz1399436
Signed-off-by: Tong Li <tonli@redhat.com>
---
So, here you can put V2 justification like:
Changes since V1: deleted rhcrashkernel-param file as well now.~Pratyush
kexec-tools.spec | 2 --
rhcrashkernel-param | 6 ------
2 files changed, 8 deletions(-)
delete mode 100644 rhcrashkernel-param
diff --git a/kexec-tools.spec b/kexec-tools.spec
index 1a8aa70..2518fcc 100644
--- a/kexec-tools.spec
+++ b/kexec-tools.spec
@@ -19,7 +19,6 @@ Source12: mkdumprd.8
Source14: 98-kexec.rules
Source15: kdump.conf.5
Source16: kdump.service
-Source17: rhcrashkernel-param
Source18: kdump.sysconfig.s390x
Source19: eppic_050615.tar.gz
Source20: kdump-lib.sh
@@ -203,7 +202,6 @@ install -m 644 %{SOURCE15} $RPM_BUILD_ROOT%{_mandir}/man5/kdump.conf.5
install -m 644 %{SOURCE16} $RPM_BUILD_ROOT%{_unitdir}/kdump.service
install -m 755 -D %{SOURCE22} $RPM_BUILD_ROOT%{_prefix}/lib/systemd/system-generators/kdum p-dep-generator.sh
mkdir -p $RPM_BUILD_ROOT/usr/sbin
-install -m 755 %{SOURCE17} $RPM_BUILD_ROOT/usr/sbin/rhcrashkernel-param
%ifarch %{ix86} x86_64 ppc64 s390x ppc64le
install -m 755 makedumpfile-1.6.0/makedumpfile $RPM_BUILD_ROOT/sbin/makedumpf ile
diff --git a/rhcrashkernel-param b/rhcrashkernel-param
deleted file mode 100644
index a823e4b..0000000
--- a/rhcrashkernel-param
+++ /dev/null
@@ -1,6 +0,0 @@
-#!/bin/sh
-if grep -q Fedora /etc/redhat-release; then
- echo -n
-else
- echo crashkernel=auto
-fi