Hi Dave and Coiby,
Thanks for reviewing the patch. After the discussion with Dave, we
think it's better to keep the original lzo as default comp for making
vmcore. So I'd like to withdraw the patch. Sorry for the
inconvenience.
Thanks,
Tao Liu
On Fri, Jan 14, 2022 at 1:09 PM RuiRui Yang <ruyang(a)redhat.com> wrote:
Hi Tao and Coiby,
On Fri, 14 Jan 2022 at 12:31, Coiby Xu <coxu(a)redhat.com> wrote:
>
> Hi Tao,
>
> There are other places where you need to replace "makedumpfile -l" with
> "makedumpfile -z" as well,
>
> $ grep "makedumpfile.* -l" *
> dracut-kdump.sh:19:DEFAULT_CORE_COLLECTOR="makedumpfile -l --message-level 7 -d
31"
> kdump.conf:71:# "makedumpfile -F -l --message-level 7 -d 31".
> kdump.conf:73:# "makedumpfile -l --message-level 7 -d 31".
> kdump.conf:181:core_collector makedumpfile -l --message-level 7 -d 31
> kdump.conf.5:94:"makedumpfile -F -l --message-level 7 -d 31".
> kdump.conf.5:96:"makedumpfile -l --message-level 7 -d 31".
> kdump.conf.5:327:core_collector "makedumpfile -l --message-level 7 -d 31"
> kdump.conf.5:331:makedumpfile -l --message-level 7 -d 31 /proc/vmcore
<dest-path>/vmcore
> kdump.conf.5:348:core_collector "makedumpfile -F -l --message-level 7 -d
31"
> kdump.conf.5:352:makedumpfile -F -l --message-level 7 -d 31 | dd
of=<target-device>
> kdump.conf.5:364:core_collector "makedumpfile -F -l --message-level 7 -d
31"
> kdump.conf.5:368:makedumpfile -F -l --message-level 7 -d 31 | ssh <options>
<remote-location> "dd of=path/vmcore"
> kexec-kdump-howto.txt:696:A typical setup is 'core_collector makedumpfile -F -l
--message-level 7 -d 31',
> kexec-kdump-howto.txt:716: core_collector "makedumpfile -l --message-level 7 -d
31"
> kexec-kdump-howto.txt:720: makedumpfile -l --message-level 7 -d 31 /proc/vmcore
<dest-path>/vmcore
> kexec-kdump-howto.txt:739: core_collector "makedumpfile -F -l --message-level 7
-d 31"
> kexec-kdump-howto.txt:743: makedumpfile -F -l --message-level 7 -d 31 | dd
of=<target-device>
> kexec-kdump-howto.txt:757: core_collector "makedumpfile -F -l --message-level 7
-d 31"
> kexec-kdump-howto.txt:761: makedumpfile -F -l --message-level 7 -d 31 | ssh
<options> <remote-location> "dd of=path/vmcore"
> kexec-kdump-howto.txt:779:"makedumpfile -F -l --message-level 7 -d 31".
> kexec-kdump-howto.txt:781:"makedumpfile -l --message-level 7 -d 31".
>
> On Wed, Dec 22, 2021 at 02:03:30PM +0800, Tao Liu wrote:
> >Currently zstd has been supported both for makedumpfile and crash
> >utility. So let's use zstd as the default vmcore compression method
> >instead of lzo.
Maybe we should be cautious to switch the default compression method, as from Tao's
test data it seems lzo is using less time, so people may want less time instead of
choosing a better comp ratio. The patch log did not tell why we need to switch to zstd,
so unless we have enough good reason, it would be better to keep the original default comp
method. What do you think?
>
> >
> >Signed-off-by: Tao Liu <ltao(a)redhat.com>
> >---
> > kdump.conf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/kdump.conf b/kdump.conf
> >index dea2e94..502730e 100644
> >--- a/kdump.conf
> >+++ b/kdump.conf
> >@@ -171,7 +171,7 @@
> > #ssh user@2001:db8::1:2:3:4
> > #sshkey /root/.ssh/kdump_id_rsa
> > path /var/crash
> >-core_collector makedumpfile -l --message-level 7 -d 31
> >+core_collector makedumpfile -z --message-level 7 -d 31
> > #core_collector scp
> > #kdump_post /var/crash/scripts/kdump-post.sh
> > #kdump_pre /var/crash/scripts/kdump-pre.sh
> >--
> >2.33.1
> >
>
> --
> Best regards,
> Coiby
> _______________________________________________
> kexec mailing list -- kexec(a)lists.fedoraproject.org
> To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
> Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure