On Tue, Jun 08, 2021 at 10:24:28PM +0800, Kairui Song wrote:
On Tue, Jun 8, 2021 at 9:41 AM Kairui Song <kasong(a)redhat.com>
wrote:
>
> On Mon, Jun 7, 2021 at 2:47 PM Coiby Xu <coxu(a)redhat.com> wrote:
> >
> > v3 -> v2:
> >
> > 1. selftest: kill VM reliably
> > - only kill if there are subjobs belonging to a pid
> >
> > 2. selftest: ignore all spaces when compare the dmesg files (new)
> >
> >
> > v1 -> v2:
> >
> > 1. selftest: kill VM reliably
> > - use $_jobs instead of `echo $_jobs` to iterate jobs
> > - fix format issue
> > 2. selftest: Make test_base_image depends on EXTRA_RPMS (new)
> >
> > Coiby Xu (4):
> > selftest: fix the error of misplacing double quotes
> > selftest: kill VM reliably
> > selftest: Make test_base_image depends on EXTRA_RPMS
> > selftest: ignore all spaces when compare the dmesg files
> >
> > tests/Makefile | 2 +-
> > tests/scripts/kexec-kdump-test/init.sh | 2 +-
> > tests/scripts/run-test.sh | 17 +++++++++++++----
> > tests/scripts/test-lib.sh | 3 +--
> > tests/scripts/testcases/nfs-kdump/0-server.sh | 2 +-
> > 5 files changed, 17 insertions(+), 9 deletions(-)
> >
> > --
> > 2.31.1
> > _______________________________________________
> > kexec mailing list -- kexec(a)lists.fedoraproject.org
> > To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
> > Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
> > Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
>
> Great work, thanks for the series!
>
> Acked-by: Kairui Song <kasong(a)redhat.com>
>
After more tests, patch 2/4 seems problematic, it causes errors when
the test is interrupted manually and may kill irrelevant processes ,
other patches look good, I'll merge every patch except 2/4.
Thanks for merging other patches! I've sent v4 to address the issues
found by you.
> --
> Best Regards,
> Kairui Song
--
Best Regards,
Kairui Song
--
Best regards,
Coiby