On Mon, 2015-10-19 at 17:02 +0800, Minfei Huang wrote:
It's better to remove/add command parameters, if
KDUMP_COMMANDLINE is
none, otherwise we shouldn't do anything.
Also IMHO, we may append the command parameters before removing the
parameters in KDUMP_COMMANDLINE_REMOVE.
if [ -z "$KDUMP_COMMANDLINE" ]; then
cmdline=`cat /proc/cmdline`
+ cmdline="${cmdline} ${KDUMP_COMMANDLINE_APPEND}"
+ cmdline=`remove_cmdline_param "$cmdline"
${KDUMP_COMMANDLINE_REMOVE}`
else
cmdline=${KDUMP_COMMANDLINE}
fi
- cmdline=`remove_cmdline_param "$cmdline" crashkernel
hugepages hugepagesz panic_on_warn slub_debug`
-
Thanks
Minfei
Talked with Dave Yang, this will break the backward compatibility..
Also, for backward compatibility, we need to set a default value for
KDUMP_COMMANDLINE_REMOVE in kdumpctl.
Dangyi