On 06/02/16 at 04:21pm, Xunlei Pang wrote:
On 2016/06/02 at 15:46, Dave Young wrote:
Hi, Xunlei
Seems I sent wrong draft, here is the right one:
Add a question about below --add-driver "nfs nfsv4"
Why should we add them? if we addes dracut 95nfs module then it will install all the nfs kernel modules and network module.
Yeah, dracut 95nfs module has installkernel() { instmods nfs sunrpc ipv6 nfsv2 nfsv3 nfsv4 nfs_acl nfs_layout_nfsv41_files }
But actually during my test, I found that if nfs was not mounted, some of the modules (for example nfsv4)will fail to be installed by instmods.
Hmm, it may related to we use hostonly, could you check the instmods function to see if we can handle it without adding drivers in dracut args?
But I have a concern, if the network can be setup correctly. Kdump still will find the right nic and set it up?
The implementation patch added:
dracut_args)
if is_nfs_in_dracut_args "$config_val"; then
kdump_install_net "$(get_dracut_args_target "$config_val")"
fi
;;
So the net device when specifying nfs can be installed correctly.
Ok, cool then it should be ok.
BTW, for patch 1 I have not got time to think about it, maybe I will reply tomorrow.
Thanks Dave