On Thu, Apr 1, 2021 at 3:38 PM Coiby Xu coxu@redhat.com wrote:
ifcfg scripts are deprecated. kexec-tools still set up network based on ifcfg scripts which lead to the issues like [1] [2].
We can get network configuration including dns, bond and znet by parsing nmcli output instead. Another benefit is we could potentially avoid subtle bugs caused by namespace pollution because of sourcing ifcfg scripts.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1919052 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1933679
v1 -> v2:
- Use "nmcli --get-values" to extract the value by filed directly [Kairui]
- Keep compatibility with network scripts [Kairui]
- kdumpctl will exit when failing to set up znet or bond cmdline
- Warn the user when network scripts are used
dracut-module-setup.sh | 105 +++++++++++++++++++++++++++++++---------- kdump-lib.sh | 48 +++++++++++++++++++ 2 files changed, 128 insertions(+), 25 deletions(-)
-- 2.31.0 _______________________________________________ kexec mailing list -- kexec@lists.fedoraproject.org To unsubscribe send an email to kexec-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Looks good to me. Acked-by: Kairui Song kasong@redhat.com