On 08/01/2017 at 09:38 AM, Xunlei Pang wrote:
On 07/31/2017 at 06:17 PM, Xunlei Pang wrote:
> Currently, systemd uses 90s as the default mount unit timeout,
> in some cases, although it works well in 1st kernel, it's not
> enough under kdump and results in mount timeout, further results
> in kdump dumping failure.
>
> We've met several such issues, we decided to enlarge this default
> value a little for kdump.
>
> We finalize "x-systemd.device-timeout=300" as the default timeout
> to the mount options if there is no "x-systemd.device-timeout=X"
> specified. It can be overridden by /etc/fstab mount options,etc,
> so that users can specify other timeout values if they want to.
>
> Note: this is different from rd.timeout which was introduced by
> dracut initqueue.
>
> Signed-off-by: Xunlei Pang <xlpang(a)redhat.com>
> ---
> v1->v2:
> -Use 300s other than 600s as the default value.
>
> mkdumprd | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/mkdumprd b/mkdumprd
> index d3ecbd6..29e51a9 100644
> --- a/mkdumprd
> +++ b/mkdumprd
> @@ -104,6 +104,12 @@ to_mount() {
> _options=$(echo $_options | sed 's/noauto//')
> _options=${_options/#ro/rw} #mount fs target as rw in 2nd kernel
>
> + # kdump turns out to require longer default systemd mount timeout
> + # than 1st kernel(90s by default), we choose 300s for kdump.
> + if ! strstr $_options "x-systemd.device-timeout"; then
> + _options="$_options,x-systemd.device-timeout=300"
BTW, I've tested nfs mount, seems no side effect to add this option for it,
but I think we better not do it for nfs.
I am planning to do this by adding a new /etc/systemd/system.conf.d/kdump.conf
under kdump, so this will be solved naturally.
Another issue is that when testing root mount(/sysroot), this timeout option
doesn't seems to work, so I think we can change all kinds of mount under
kdump to use /kdumproot/?
After coding for a while, I found that we have to handle fadump separately
which makes the code uglier, given that we only met such issues on non-root
targets, so I preferred not handling it currently.
Regards,
Xunlei
Maybe I can send v3. @Dave, what do you think?
Regards,
Xunlei
> + fi
> +
> _mntopts="$_target $_fstype $_options"
> #for non-nfs _dev converting to use udev persistent name
> if [ -b "$_source" ]; then