On 06/09/14 at 01:07pm, Vivek Goyal wrote:
On Mon, Jun 09, 2014 at 07:01:32PM +0800, WANG Chao wrote:
[..]
> > I am really not convinced that if keys are wrong that we should continue
> > to retry. Expect string of bugs on this.
>
> The question is how we can distinguish the case of wrong keys and
> network disconnection. ssh utility always returns 255 in failure.
>
> What's more is network disconnection can be various reasons:
> - local network isn't ready yet (no ip address)
> - host network isn't ready yet.
> - network connection somehow fails:
> - router isn't working this time.
> - packet lost because connection isn't stable.
I don't think we can take care of issues like router isn't working. packet
lost should be taken care by TCP/IP protocol.
You're right. Those are not the cases we should take care.
>
> I agree that we should treat the issue of wrong keys differently from
> other issues. But the question is how we can seperate. As long as it's
> figured out, we can handle this kind of failure differently ...
I would say for the time being let us not do anything. Let us keep looking
and once we better ideas, we can write a patch. Retrying upon key
verification failure is going to create us more problems than it solves
for us.
I agree. I'll hold off. If there's a real world demand in the future, we
can always look back.