On 07/29/14 at 09:00am, Vivek Goyal wrote:
On Mon, Jul 28, 2014 at 09:48:41PM +0800, WANG Chao wrote:
> > > No. dracut-initqueue is configured by dracut and it's emergency
> > > is dracut-emergency.service.
> > But I thought we disabled dracut-emergency.service. So are you saying
> > that if failure happens early, then dracut emergency handler will run.
> > But that will put us on shell instead of rebooting?
> We've disabled dracut-emergency.service, so failure of dracut-initqueue
> is ignored and systemd would just continue to run kdump.sh
> Rethinking another round, I think it's better to enable dracut-emergency
> service but replace it with our own error handler. So that we can fail
> early and run kdump error handler, instead of ignoring the failure.
I agree. If error happens early, we should launch our own error handler
early instead of continuing to boot.
This will limit our choices of what we can do in error handling. I am not
sure what will happen if you try to start initqueue and mount root again
inside error handler (dump_to_rootfs), when error has happened this early.
I just sent an update for both cleanup and error handling. Please take a
look when you have time.