On 08/30/2017 at 02:25 PM, Dave Young wrote:
Hi Xunlei,
On 08/30/17 at 10:12am, Xunlei Pang wrote:
> Currently 99kdump and 95iscsi both generate iscsi related
> cmdline, we remove that of 95iscsi and use 99kdump's, as
> we need to setup "kdump-eth*" in some software iscsi cases.
>
> Signed-off-by: Xunlei Pang <xlpang(a)redhat.com>
> ---
> dracut-module-setup.sh | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
> index ae13337..837447d 100755
> --- a/dracut-module-setup.sh
> +++ b/dracut-module-setup.sh
> @@ -612,6 +612,11 @@ kdump_check_iscsi_targets () {
> # If our prerequisites are not met, fail anyways.
> type -P iscsistart >/dev/null || return 1
>
> + # Remove software iscsi cmdline generated by dracut.
> + # Ugly: generate here mainly due to kdump_setup_ifname().
> + grep "ip=ibft" ${initdir}/etc/cmdline.d/95iscsi.conf
&>/dev/null
> + [ $? -ne 0 ] && rm -rf ${initdir}/etc/cmdline.d/95iscsi.conf
> +
Is the duplicate cmdline caused by using --hostonly-cmdline? If so
it is better to add this in patchlog.
Yes, will improve.
Regards,
Xunlei
> kdump_check_setup_iscsi() (
> local _dev
> _dev=$1
> --
> 1.8.3.1
>
Thanks
Dave