> > - local nodes
> > - is_pcs_fence_kdump || return 1
> > + local kdump_cfg_file=$1
> > +
> > + if [ -z "$FENCE_KDUMP_NODES" ]; then
> Why do we need to check for zero FENE_KDUMP_NODES? Will following call
> of is_pcs_fence_kdump() not take care of it.
Configuration using fence_kdump_nodes option in kdump.conf has higher priority,
so when it's configured, we will ignore old Pacemaker configuration
Ok, so once you move to code structure as suggested below, you will not
have to check for this. You will always check for generic cluster first
and it gets priority.
nodes = get_generic_fence_kdump_nodes();
nodes = get_pcs_fence_kdump_nodes;
> > +Please be aware that these two ways cannot be combined and
> > precedence
> > +over 1): if you specify fence_kdump_nodes option, it will be used to
> > configure
> > +fence_kdump even if you configured fence_kdump in Pacemaker cluster!
> So for the vdsm case, don't we have fence_kdump running somewhere which
> receives messages from fence_kdump_send.
Yes, configuration of this listener will be part of oVirt, but it doesn't
have any direct impact on kdump configuration.
I think I am not clear about the language of the text. What does following
1) if you specify fence_kdump_nodes option, it will be used to configure
fence_kdump even if you configured fence_kdump in Pacemaker cluster!
What are you referring to when you say "fence_kdump" above?