On 07/08/19 at 12:59am, Kairui Song wrote:
On Tue, Jul 2, 2019 at 10:13 AM Dave Young <dyoung(a)redhat.com>
> Hi Kairui,
> On 06/28/19 at 11:11pm, Kairui Song wrote:
> > Don't use any log storage and forward to console directly, this make
> > console output more useful, and also save more memory. On a fresh
> > installed Fedora 30 it saved ~5M of memory, and the amount of log being
> > printed to console is still acceptable.
> looks nice, only concern is if we could get lots of systemd debug msgs
> so that it floods the console output, otherwise it is a good idea.
> could you double check that?
Yes, it will increase the console output line number for sure, but the
content won't increase much (~700 lines without the patch, to ~800
lines of log with the patch in my VM test, similiar result with
nfs/local dump), and the system log is printed to the console
gradually as boot progresses, so it should be fine.
Ok, then looks good:
Acked-by: Dave Young <dyoung(a)redhat.com>