On 04/22/16 at 10:54pm, Xunlei Pang wrote:
On 2016/04/22 at 17:26, Minfei Huang wrote:
> On 04/21/16 at 03:44pm, Xunlei Pang wrote:
>> There are two issues by doing this:
>> 1) The dns sequence is different from that in 1st system.
>> 2) There are some duplicated items.
>> NOTE: kdump_setup_dns() meant to avoid the duplication,
>> but the original shell command is actually disfunctional:
>> "[ ! $(cat $_dnsfile | grep -q $_dns) ]" (always true)
> Hi.
>
> This test is useful in previous context, since there may be duplicate
> DNS entries in /etc/resolv.conf. It is safe to remove it in your patch,
> because the deplicate DNS entries will be remove later.
Actually, this condition always returns true, you can test it :-)
Thanks for pointing it out.
This error is caused by misusing brackets. Removing this brackets can
make this test work. It's lucky that kdump can work as well, although
there are duplicate DNS entry in resolv.conf.
Thanks
Minfei