On 05/14/2015 10:33 AM, Baoquan He wrote:
On 05/14/15 at 10:20am, Qiao Zhao wrote:
> Customer found when specify "noauto" option in fstab for nfs mount,
> dump failed.
>
> The reason is if "noauto" option is specified in fstab, the mount entry
> in fstab related to dump target will passed to dracut and stored in
> kdump initrd. Then during kdump kernel boots this entry containing
> "noauto" will be ignored by mount service. This cause dump failing.
> In fact with "noauto" not only nfs dump will fail, non-root disk dump
> will fail too. root disk dump can dump successfully since root disk can
> always be mounted by systemd.
>
> So now "noauto" need be filtered out when the fstab entry corresponding
> to dump target contains "noauto".
> ---
> mkdumprd | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mkdumprd b/mkdumprd
> index 4d251ba..216354d 100644
> --- a/mkdumprd
> +++ b/mkdumprd
> @@ -114,6 +114,8 @@ to_mount() {
> _fstype=$(findmnt -k -f -n -r -o FSTYPE $_dev)
> _options=$(findmnt --fstab -f -n -r -o OPTIONS $_dev)
> [ -z "$_options" ] && _options=$(findmnt -k -f -n -r -o
OPTIONS $_dev)
> + # "noauto" options will fail dump, remove "noauto" in 2nd
kernel fstab.
Hi Qiao,
Your code comment is not clear enough. I think 2 options for this:
1)either remove it,
2)or make it clear like:
#With 'noauto' in fstab nfs and non-root disk mount will fail in 2nd
kernel, filter it out here
I think way2 is good for me. Will re-write patch.
--
Thanks,
Qiao
It's up to you.
Thanks
Baoquan
> + _options=$(echo $_options | sed 's/noauto//')
> _options=${_options/#ro/rw} #mount fs target as rw in 2nd kernel
> # "x-initrd.mount" mount failure will trigger isolate emergency
service
> # W/o this, systemd won't isolate, thus we won't get to emergency.
> --
> 1.9.3
>
> _______________________________________________
> kexec mailing list
> kexec(a)lists.fedoraproject.org
>
https://lists.fedoraproject.org/mailman/listinfo/kexec