On 04/21/16 at 12:11pm, Pratyush Anand wrote:
Hi Bao,
On 21/04/2016:02:28:48 PM, Baoquan He wrote:
> On 04/21/16 at 11:16am, Pratyush Anand wrote:
> > If a disk is mounted on /var/crash, and is changed from /dev/diskA to
> > /dev/diskB then rebuild. If /var/crash and / have been mounted on same disk
> > but now a different disk is mounted at /var/crash then also rebuild.
>
> Thanks for so quick response. A tiny bit concern about patch log, here
> /var/crash is a default dump path, which is a specific name. User could
> specify their own favorite place which is different than /var/crash, and
> meantime doesn't specify target, this patch can also fix it. It may be
> better to use "dump path" which is a general. My personal opinion.
It's
> up to you and fedora maintainer - Dave.
>
> Patch is great.
Thanks :-)
Agreed, commit log can be improved. If there would not be any comment then I
will send V2 with improved log. Will wait for some time for other review
comments.
Sounds great, thanks! :)
>
> ~Pratyush
> _______________________________________________
> kexec mailing list
> kexec(a)lists.fedoraproject.org
>
http://lists.fedoraproject.org/admin/lists/kexec@lists.fedoraproject.org