On 2016/05/24 at 16:41, Dave Young wrote:
Hi,
>>> {
>>> local _host
>>> - if is_nfs_dump_target || is_ssh_dump_target
>>> + if is_nfs_dump_target || is_ssh_dump_target ||
dracut_args_contains_nfsmount
>> What about for the name is_dracut_args_contain_nfsmount? It will match other
>> nomenclature.
>> Similarly for is_dracut_args_contain_mount.
> "contain" is a verb, using "is_" prefix is probably not improper,
is "does_" prefer better?
Or just add the check in is_nfs_dump_target function itself in kdump-lib.sh
For "dracut_args_contains_nfsmount", I think it's nice.
But we still need to have "dracut_args_contains_mount".
Regards,
Xunlei
Thanks
Dave