On Thu, Mar 27, 2014 at 03:14:32PM -0400, Vivek Goyal wrote:
On Wed, Mar 26, 2014 at 10:24:07AM +0100, Martin Perina wrote:
> Bug-Url: https://bugzilla.redhat.com/1079821
> Signed-off-by: Martin Perina <mperina(a)redhat.com>
Can you provide changelog explaining what this patch is doing. We put
appropriate changelog for every patch in the series.
Also in general, have you tested it? Last time you mentioned that from
vdsm side you folks are still debating which method to use. I am assuming
that means vdsm code is not ready yet and that probably means this
patchset might be untested?
> diff --git a/kdumpctl b/kdumpctl
> index 8d5498a..24fb988 100755
> --- a/kdumpctl
> +++ b/kdumpctl
> @@ -249,8 +249,8 @@ function check_rebuild()
> EXTRA_BINS="$EXTRA_BINS $CHECK_FILES"
> files="$KDUMP_CONFIG_FILE $kdump_kernel $EXTRA_BINS"
> - if [ -f $FENCE_KDUMP_CONFIG ]; then
> - files="$files $FENCE_KDUMP_CONFIG"
> + if [ -f $FENCE_KDUMP_CONFIG_FILE ]; then
> + files="$files $FENCE_KDUMP_CONFIG_FILE"
why don't we get rid of this fence kdump config file. I thought we agreed
that fence_kdump_send options will be specified in /etc/kdump.conf using
a new option.
No package owns /etc/sysconfig/fence_kdump_send. So trying to retain
it does not make sense.
We generate a kdump.conf internal to initramfs. We can start generating
that file to put fence_kdump options and fence_kdump nodes in that file
even for pacemaker.
So dracut-module-kdump.sh implementation will always expect that fence
kdump optoins and nodes are passsed in /etc/kdump.conf.
It is only kdumpctl implementation which will look for these options in
/etc/kdump.conf and if it is not there it will assume we are dealing
with pacemaker and use existing code of pcs to get to list of nodes.
For fedora we can change options method even for pcs and now make it
mandatory that fence kdump options need to be passed through
We should talk to pacemaker folks and figure out how can we pass
nodes also using /etc/kdump.conf so that they also make use of this
new API instead of kdump doing special processing for pcs.