On 06/18/15 at 07:45pm, Minfei Huang wrote:
On 06/18/15 at 01:46pm, Dave Young wrote:
> On 06/18/15 at 10:12am, Dave Young wrote:
> > On 06/15/15 at 04:33pm, Minfei Huang wrote:
> >
> > Thinking more about it, You may need fix it in dracut, and then backport to
mkdumprd.
> >
> > It is btrfs specific so only doing this for btrfs case is better..
>
> We have already a bug for cleaning up get persistant dev functions:
>
https://bugzilla.redhat.com/show_bug.cgi?id=1077921
Hi, Dave.
I think a bit for this issue. How about do the cleanup firstly? As Vivek
suggested, we can define the get_persistent_dev function in
kdump-lib.sh. Thus mkdumprd and dracut-module-setup.sh can use this
function.
I agree that doing cleanup first is better. dracut-modules-setup.sh directly
use the dracut lib function, but since mkdumprd can not use it so we copied
one to mkdumprd.
Maintain two copies is bad, so we need make mkdumprd to use the dracut function.
Above is the fisrt section, then I can post a patch to fix the btrfs
issue.
For dracut, I do not want to fix it now, since there is no customer to
complain about it. If the bug needs to be fixed, I can post a patch to
fix it.
We should be aligh with dracut functions, moving functions to dracut if it
is general thing.
Thanks
Dave