Hi Raghavendra,
Thanks for your commit, but I don't think it's a good idea to change an
option from invalid
to deprecated, and "nfs4" has never been a valid option before, no reason
to mark as deprecated.
On Mon, Sep 17, 2018 at 8:15 AM Raghavendra Rao <ragrao(a)redhat.com> wrote:
Can somebody offer Ack/Nack on this please?
It has almost been a month since the initial mail.
On Tue, Aug 21, 2018 at 6:55 PM, Raghavendra Rao <ragrao(a)redhat.com>
wrote:
> Maybe this should be for RHEL 7 as I doubt we ever used 'nfs4' in fedora
> kexec-tools the way we still use in RHEL 6.
>
> Do let me know.
>
> On Tue, Aug 21, 2018 at 5:16 PM, Raghavendra Rao <ragrao(a)redhat.com>
> wrote:
>
>> Rather than calling out 'nfs4' as an invalid config option within
>> kdump.conf, it would be ideal to label it as "deprecated" as its no
>> longer used. This is because nfs shares are expected to be mounted
>> beforehand hence no special care needs to taken with respect to NFS
>> versions.
>>
>> Only when opting for dracut_args, one can specify the NFS version
>> explicitly.
>>
>> Signed-off-by: Raghavendra Rao <ragrao(a)redhat.com>
>> ---
>> kdumpctl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kdumpctl b/kdumpctl
>> index 6a01c13..b81df9a 100755
>> --- a/kdumpctl
>> +++ b/kdumpctl
>> @@ -229,7 +229,7 @@ check_config()
>> return 1;
>> }
>> ;;
>> -
>> net|options|link_delay|disk_timeout|debug_mem_level|blacklist)
>> +
>> net|nfs4|options|link_delay|disk_timeout|debug_mem_level|blacklist)
>> echo "Deprecated kdump config option:
>> $config_opt. Refer to kdump.conf manpage for alternatives."
>> return 1
>> ;;
>> --
>> 1.8.3.1
>> _______________________________________________
>> kexec mailing list -- kexec(a)lists.fedoraproject.org
>> To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
>> Fedora Code of Conduct:
https://getfedora.org/code-of-conduct.html
>> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
>> List Archives:
>>
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.o...
>>
>
>
_______________________________________________
kexec mailing list -- kexec(a)lists.fedoraproject.org
To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://getfedora.org/code-of-conduct.html
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
--
Best Regards,
Kairui Song