Hi Philipp,
Thanks for the review.
On 23/11/22 5:38 pm, Philipp Rudo wrote:
Hi Hari,
On Mon, 21 Nov 2022 17:48:01 +0530
Hari Bathini <hbathini(a)linux.ibm.com> wrote:
> In case of fadump, default initrd is rebuilt with dump capturing
> capability, as the same initrd is used for booting production kernel
> as well as capture kernel.
>
> The original initrd file is backed up with a checksum, to restore
> it as the default initrd when fadump is disabled. As the checksum
> file is not kernel version specific, switching between different
> kernel versions and kdump/fadump dump mode breaks the default initrd
> backup/restore logic. Fix this by having a kernel version specific
> checksum file.
>
> Signed-off-by: Hari Bathini <hbathini(a)linux.ibm.com>
Thanks for taking care!
Two small comments:
1) in backup_default_initrd you should remove the checksum file in the
error case, when the initrd cannot be backed up (this should
probably be done today already...)
2) why don't you simply update INITRD_CHECKSUM_OCATION one instead of
editing every line where it is used? For example consider the patch
below. I see multiple benefits (1) it's shorter, (2) the name shows
clearer to which initrd the checksum belongs to, (3) it reuses
KDUMP_BOOTDIR instead of hard coding /boot and (4)
INITRD_CHECKSUM_LOCATION now is basically local to setup_initrd now
making it easier for a clean up to remove the global variable later
on.
What do you think?
Yeah. Makes it much better and simpler. Will respin with the change.
Thanks
Hari