Hi,
I had two comments like the following
----- Original Message -----
From: "Dave Young" <dyoung(a)redhat.com>
To: "Ziyue Yang" <ziyang(a)redhat.com>
Cc: kexec(a)lists.fedoraproject.org
Sent: Tuesday, July 25, 2017 2:56:46 PM
Subject: Re: [PATCH] kdump-lib.sh: support dump ssh via local ipv6 address
Hi Ziyue,
On 07/18/17 at 12:48pm, Ziyue Yang wrote:
> When dumping to ssh via local ipv6 address, the ssh parameter
> in kdump.conf is supposed to have the form like
>
> ssh user@fe80::cc1:8bff:fe90:b95f%eth0
>
Shall we use "[]" for ipv6 addr? I.e user@[fe80::cc1:8bff:fe90:b95f%eth0] ?
> where "%eth0" is an existing network interface
supporting ipv6.
>
> However, the get_remote_host function in kdump-lib.sh currently
> doesn't remove the network interface in the ipv6 address,
> causing the ip command in kdump_install_net function to fail,
> leading to a "Bad kdump location" message.
>
> This patch supports dumping ssh via local ipv6 address by enabling
> get_remote_host function to remove network interface in ipv6 addresses
> if there are any.
The patch looks good, but I still want to defer this until Pingfan
get the ipv6 test cases passed.
During my test, the dump failed, since in 2nd kernel, the eth0 is renamed as kdump-eth0,
but the kdump still use the ipaddr fe80::cc1:8bff:fe90:b95f%eth0.
Regards,
Pingfan
> >
> > Signed-off-by: Ziyue Yang <ziyang(a)redhat.com>
> > ---
> > kdump-lib.sh | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/kdump-lib.sh b/kdump-lib.sh
> > index 3f0af91..cca68e5 100755
> > --- a/kdump-lib.sh
> > +++ b/kdump-lib.sh
> > @@ -323,6 +323,10 @@ get_remote_host()
> > _config_val=${_config_val%:/*}
> > _config_val=${_config_val#[}
> > _config_val=${_config_val%]}
> > + # factor out network inteface segment in local ipv6 address
> > + if is_ipv6_address $_config_val; then
> > + _config_val=${_config_val%%%*}
> > + fi
> > echo $_config_val
> > }
> >
> > --
> > 2.9.3
> > _______________________________________________
> > kexec mailing list -- kexec(a)lists.fedoraproject.org
> > To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
>
> Thanks
> Dave
> _______________________________________________
> kexec mailing list -- kexec(a)lists.fedoraproject.org
> To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
>