On Thu, Aug 01, 2013 at 02:36:54PM +0800, WANG Chao wrote:
On 08/01/13 at 02:35pm, Dave Young wrote:
> Thanks for the patch
>
> On 08/01/2013 01:11 PM, WANG Chao wrote:
> > We should output a message if dump vmcore fails.
> >
> > Signed-off-by: WANG Chao <chaowang(a)redhat.com>
> > ---
> > dracut-kdump.sh | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/dracut-kdump.sh b/dracut-kdump.sh
> > index 5d18b9a..dea8e9f 100755
> > --- a/dracut-kdump.sh
> > +++ b/dracut-kdump.sh
> > @@ -314,6 +314,7 @@ if [ $? -ne 0 ]; then
> > fi
> >
> > if [ $DUMP_RETVAL -ne 0 ]; then
> > + echo "kdump: saving vmcore fail"
>
> s/fail/failed?
Not sure, I'm just following this line:
echo "kdump: saving vmcore complete"
"failed" is better. Please use that.
Also print error message immediately after calling $DUMP_INSTRUCTION and
before calling kdump_post.
Thanks
Vivek