On 06/23/15 at 03:27pm, Dave Young wrote:
On 06/19/15 at 11:56am, Minfei Huang wrote:
> On 06/19/15 at 10:40am, Dave Young wrote:
> > > > > - _netdev=`/sbin/ip route get to $_server 2>&1`
> > > > > - [ $? != 0 ] && echo "Bad kdump location:
$config_val" && exit 1
> > > > > + if is_ipv6_host $_server; then
> > > > > + _netdev=`/sbin/ip -6 route get to $_server
2>&1`
> > > > > + [ $? != 0 ] && echo "Bad kdump location:
$config_val" && exit 1
> > > >
> > > > Does "ip route get to hostname" works for both ip4 and
ip6?
> > >
> > > Yes, we use "ip -6" to get the ipv6 route info.
> >
> > Can we remove "-6" if it simply works for both 4 and 6? What does
"yes" means..
>
> Previously, I think we shall append the "-6" to identify the ipv6
> address, when we try to get the route info. Just now, I tested the
> command without the "-6", and it works for ipv6.
>
> Dave, How about make this as an optimized patch to be posted laster,
> since the current code works well.
Because you will add a lot of "if" "else" based on the output, so I
think
we should do it now instead fix it later, it will make the patch cleaner
easier to review.
Although it may be related a lot of code, it is sample to fix later.
Thanks
Minfei