Problem is if there's a case panic_on_warn is useful for 2nd kernel. Let's see what's the opinion from other people, since this can be specified in our kdump sysconfig file, anyway it is not a big issue.
If removal happens in kexec.c level, then there's no way to add panic_on_warn to 2nd kernel.
I agree it's not a big issue. Let's wait and see.
Just thinking this through. Suppose someone did want panic_on_warn on the second kernel.
1. The 2nd kernel would stop booting and kdump would fail. 2. The _only_ difference in the stack trace is that we panic vs WARN. That is, if panic_on_warn is not specified you would still have the same amount of information on the 2nd kernel.
So I think there is no advantage to adding panic_on_warn to the 2nd kernel.
P.
Thanks WANG Chao