From: Justin Forbes on gitlab.com
If I need to push an other version I can add the Fedora update as
MR already got way bigger than I expected. So I don't see a problem
one more commit.
Either way, if you do it in this request, I am happy to take it. If it goes in
as a separate MR, fedora specific changes do not require the same ack
structure. I review/ack/merge, though with s390x I tend to take whatever you
My understanding so far was that common/ should contain configs that
shared between ark and fedora and not that common/ contains the defaults which
can be overwritten in ark/ and fedora/.
This is indeed the case in theory, if an entry is in common, it should ideally
be the same, with no corresponding entry in fedora or ark directory. In
practice, the scripts tend to generate a bit differently. The intention is to
run a clean up script on a regular interval which consolidates entries in
fedora and ark if they are the same, and removes common if they are different.
For this particular case I don't think an entry is necessary in common if they
are going to be different, but I do have to ask if we really need them to be
different. Does Fedora need to support older hardware here? I am fine with
either answer, I really don't know what hardware people are running Fedora on